fix(mcp-core): Allow null for externalSlug/externalId in RepositorySchema - #1297
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SentryApiService.listRepos()method was throwing aZodErrorwhen parsing responses from the Sentry API. This occurred because theRepositorySchemainpackages/mcp-core/src/api-client/schema.tsdefinedexternalSlugandexternalIdasz.string().optional(). While.optional()allowsundefined, it rejectsnull.The Sentry
/organizations/{org}/repos/endpoint, however, returnsnullfor these fields when a repository is not linked to an external SCM, leading to validation failures.This fix updates
externalSlugandexternalIdinRepositorySchematoz.string().nullish(), which correctly acceptsstring | null | undefined. This aligns with the handling ofintegrationIdin the same schema.A regression test has been added to
packages/mcp-core/src/api-client/client.test.tsto ensure that repositories withnullvalues for these fields are parsed successfully.Fixes MCP-SERVER-G2P
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.