fix(sentry): Drop client-side JsonRpcError_-32603 validation errors - #1282
Open
sentry[bot] wants to merge 1 commit into
Open
fix(sentry): Drop client-side JsonRpcError_-32603 validation errors#1282sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of excessive and unactionable
JsonRpcError_-32603events being reported to Sentry.These errors originate from the MCP server's transport integration capturing JSON-RPC
-32603responses, which are often triggered by malformed client requests (e.g., missing or incorrect parameters ininitializecalls). While-32603is technically an "Internal Error" according to the JSON-RPC spec, in this context, they represent client-side validation failures rather than genuine server bugs requiring immediate attention.To reduce noise and improve the signal-to-noise ratio in Sentry, this change adds a filter to the
sentryBeforeSendhook inpackages/mcp-core/src/telem/sentry.ts. It now checks if the first exception's type starts withJsonRpcError_-32603and, if so, returnsnullto prevent the event from being sent to Sentry.This approach aligns with previous attempts to address this issue (e.g., PRs #936 and #1180) which were unfortunately not merged.
Fixes MCP-SERVER-F1J
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.