fix(api, tools): Add 'array' to TraceItemAttributeType enum - #1273
Open
sentry[bot] wants to merge 2 commits into
Open
fix(api, tools): Add 'array' to TraceItemAttributeType enum#1273sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
sentry
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
ZodErrorthat occurred whensentry-mcpattempted to validate trace item attributes fetched from the Sentry API. The Sentry API recently expanded itsColumnTypeenum to include'array', but the corresponding Zod schemas and TypeScript types insentry-mcpwere not updated.Specifically, the following changes were made:
packages/mcp-core/src/api-client/client.ts: UpdatedTraceItemAttributeTypeSchema(line 349) to include'array'in itsz.enumdefinition.packages/mcp-core/src/tools/support/search-events/utils.ts: Updated the localtraceItemAttributeTypeSchema(line 953) to include'array'in itsz.enumdefinition.packages/mcp-core/src/api-client/client.ts: Updated the TypeScript typeTraceItemAttributeType(line 293) to include'array'as a valid literal type.These changes ensure that
sentry-mcpcorrectly validates and type-checks trace item attributes, preventingZodErrorwhen the Sentry API returns attributes of type'array', and resolves the CI type-checking failure.Fixes MCP-SERVER-G89
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.This PR was automatically generated by Sentry. You can adjust this setting at any time.