fix(api-client): Use ApiClientError for non-JSON 400 responses - #1269
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
SentryApiService.parseJsonResponsewould throw a plainErrorwhen it encountered a non-JSON response (e.g., HTML) for a 400 Bad Request. This plainErrorwas not recognized byisExpectedToolErroras an expected API client error, causing it to be incorrectly logged as an unhandled exception in Sentry.This change updates
parseJsonResponseto usecreateApiError(...)instead ofthrow new Error(...)for both the HTML and generic non-JSON fallback paths. This ensures that these 400 responses are correctly classified asApiClientError(specificallyApiValidationError), whichisExpectedToolErrorwill then suppress, preventing unnecessary Sentry alerts.Fixes MCP-SERVER-G2E
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.This PR was automatically generated by Sentry. You can adjust this setting at any time.