fix(attachments): stop using attachment SHA1 metadata - #1265
Merged
Merged
Conversation
Objectstore-backed attachments intentionally store empty checksums, so SHA1 from the list API is misleading. Drop it from the event attachment schema and tool output. Co-Authored-By: Jan Michael Auer <jan.auer@sentry.io>
Co-Authored-By: Jan Michael Auer <jan.auer@sentry.io>
jan-auer
marked this pull request as ready for review
August 25, 2026 13:34
lcian
approved these changes
Aug 25, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry objectstore-backed attachments intentionally store empty checksums on the attachment model.
get_event_attachmentwas still requiring and printing that SHA1, which made list output look broken even when size and download metadata were fine.This removes attachment SHA1 from the event attachment schema and from list/download tool output. Upstream API responses may still include the field; we no longer depend on it.
Ref FS-491
Ref #1267
Requested by async jauer.
--
View Junior Session [Sentry]