fix(sentry-api): prevent POST to GET conversion on 302 redirects - #1258
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1154428. Configure here.
| ...options, | ||
| headers, | ||
| redirect: "manual", | ||
| }); |
There was a problem hiding this comment.
Relative redirect URLs break fetch
High Severity
Manual redirect handling passes the raw Location value into fetch. Relative or path-only locations (common for same-host redirects) are not resolved against the original request URL, so Node and Workers fetch reject them and previously successful redirects fail.
Reviewed by Cursor Bugbot for commit 1154428. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR addresses the
ZodError: Failed to validate objectoccurring inSentryApiService.createClientKey.Problem:
When
SentryApiService.createClientKeymakes aPOSTrequest to the Sentry API (/api/0/projects/.../keys/), if the Sentry instance is configured with region silos, the initial request can return a302 Foundredirect. ThefetchAPI, with its defaultredirect: 'follow'behavior, automatically follows this redirect but incorrectly converts thePOSTrequest into aGETrequest. AGETrequest to the keys endpoint returns a list of all client keys (an array), not a single created key object. Consequently,ClientKeySchema.parse(body)fails because it expects a single object and receives an array.Solution:
To resolve this, the
request()method inpackages/mcp-core/src/api-client/client.tshas been modified:redirect: 'manual'is now explicitly set in thefetchoptions. This preventsfetchfrom automatically following redirects and converting methods.fetchcall, the code now manually checks for 3xx status codes (301, 302, 303, 307, 308) and the presence of aLocationheader.Locationheader. This ensures thatPOSTrequests remainPOSTrequests even after a redirect, allowing the client key to be created successfully and the response to be correctly parsed byClientKeySchema.Fixes MCP-SERVER-FYF
This PR was automatically generated by Sentry. You can adjust this setting at any time.