Skip to content

test: Stop slow Docker steps from failing integration and E2E tests - #26481

Merged
nicohrubec merged 3 commits into
developfrom
sig/test-docker-phases
Nov 17, 2026
Merged

nicohrubec merged 3 commits into
developfrom
sig/test-docker-phases

Conversation

@s1gr1d

@s1gr1d s1gr1d commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

What

  • Node integration tests: a slow Docker image download no longer fails the test setup. The download has its own time limit (5 minutes), separate from the container start (2 minutes).
  • AWS Lambda E2E apps: the cleanup after the tests no longer fails when all tests have passed.
  • deno and bun-mysql E2E apps: the Docker images are downloaded in the build step, not while Playwright waits for the app to start.
  • nuxt-4 and nuxt-5: when the containers do not start, the log now shows why.

Why

These jobs failed in CI because a Docker step was slow, not because a test was wrong. The most frequent case was the image download in the Node integration tests, with 52 failures in the last month.

Ref #26477
also closes #26477 because it's the last PR in the issue

`spawnSync` blocks the event loop, so the 120 s hook timeout could not stop a slow image pull.
It only failed the hook after the containers were already healthy (52 failures, pulls of up
to 237 s). The pull, each `up` attempt, `down`, and `logs` now have an enforced timeout, and
the hook timeout is the sum of them. A phase that times out names itself in the error.
`stopSam` sent SIGKILL after 5 s and went on without waiting for the exit. SAM was still
removing its warm containers, so `docker rm -f` raced that removal and failed the teardown
after all tests had passed. The fixture now waits for the exit, and a failed `docker rm` is
an error only if a container stays.
`docker compose up` runs in the `start` script, inside the 60 s web server timeout of
Playwright. A slow image pull used up that time. The build step now pulls the images.

The global setup of nuxt-4 and nuxt-5 also prints `docker compose ps -a` on a failed start,
because the logs do not show the exit code of a container that restarts.
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: e961219 (PR test merge using develop at 524bd26)

Against: 524bd26 (develop) · base run #66453

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.1 kB - -
@sentry/browser - with treeshaking flags 28.3 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.2 kB - -
@sentry/browser (incl. Tracing) 52.28 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.29 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.25 kB - -
@sentry/browser (incl. Tracing, Replay) 92.82 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.6 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.21 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.6 kB - -
@sentry/browser (incl. Feedback) 47.73 kB - -
@sentry/browser (incl. sendFeedback) 30.69 kB - -
@sentry/browser (incl. FeedbackAsync) 35.69 kB - -
@sentry/browser (incl. Metrics) 31.43 kB - -
@sentry/browser (incl. Logs) 31.71 kB - -
@sentry/browser (incl. Metrics & Logs) 32.37 kB - -
@sentry/react 32.11 kB - -
@sentry/react (incl. Tracing) 54.95 kB - -
@sentry/vue 38.29 kB - -
@sentry/vue (incl. Tracing) 55.24 kB - -
@sentry/svelte 30.12 kB - -
@sentry/remix (Remix 3 client bundle) 58.06 kB - -
CDN Bundle 31.87 kB - -
CDN Bundle (incl. Tracing) 52.7 kB - -
CDN Bundle (incl. Logs, Metrics) 34.67 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.26 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.7 kB - -
CDN Bundle (incl. Tracing, Replay) 90.72 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.33 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96.09 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.69 kB - -
CDN Bundle - uncompressed 92.98 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.45 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.33 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.08 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 231.44 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.61 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 283.24 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.02 kB - -
@sentry/nextjs (client) 58.57 kB - -
@sentry/sveltekit (client) 53.57 kB - -
@sentry/core/server 44.8 kB - -
@sentry/core/browser 14.4 kB - -
@sentry/node 151.66 kB -0.01% -5 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.33 kB - -
@sentry/node - without tracing 88.59 kB -0.01% -6 B 🔽
@sentry/node - without channel injection 140.62 kB -0.01% -3 B 🔽
@sentry/aws-serverless 98.96 kB -0.01% -7 B 🔽
@sentry/cloudflare (withSentry) - minified 206.71 kB - -
@sentry/cloudflare (withSentry) 479.81 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 232.07 kB - -

View base workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

All optional checks were successful. 4 successful. See the run.

Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5 (kv-cache) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E deno (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5 (development) Test (optional) Successful in 1m Details

@s1gr1d
s1gr1d marked this pull request as ready for review November 17, 2026 13:50
@nicohrubec
nicohrubec merged commit 807f6a5 into develop Nov 17, 2026
107 checks passed
@nicohrubec
nicohrubec deleted the sig/test-docker-phases branch November 17, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CI flakiness, make CI/tests more reliable

3 participants