Repository navigation
test: Stop slow Docker steps from failing integration and E2E tests - #26481
Merged
Merged
Conversation
`spawnSync` blocks the event loop, so the 120 s hook timeout could not stop a slow image pull. It only failed the hook after the containers were already healthy (52 failures, pulls of up to 237 s). The pull, each `up` attempt, `down`, and `logs` now have an enforced timeout, and the hook timeout is the sum of them. A phase that times out names itself in the error.
`stopSam` sent SIGKILL after 5 s and went on without waiting for the exit. SAM was still removing its warm containers, so `docker rm -f` raced that removal and failed the teardown after all tests had passed. The fixture now waits for the exit, and a failed `docker rm` is an error only if a container stays.
`docker compose up` runs in the `start` script, inside the 60 s web server timeout of Playwright. A slow image pull used up that time. The build step now pulls the images. The global setup of nuxt-4 and nuxt-5 also prints `docker compose ps -a` on a failed start, because the logs do not show the exit code of a container that restarts.
Contributor
size-limit report 📦Compared: e961219 (PR test merge using develop at 524bd26) Against: 524bd26 (develop) · base run #66453 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 4 successful. See the run. Successful checks
|
s1gr1d
marked this pull request as ready for review
November 17, 2026 13:50
javascript-sdk-gitflow
Bot
requested review from
andreiborza,
chargome and
isaacs
November 17, 2026 13:51
chargome
approved these changes
Nov 17, 2026
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
denoandbun-mysqlE2E apps: the Docker images are downloaded in the build step, not while Playwright waits for the app to start.nuxt-4andnuxt-5: when the containers do not start, the log now shows why.Why
These jobs failed in CI because a Docker step was slow, not because a test was wrong. The most frequent case was the image download in the Node integration tests, with 52 failures in the last month.
Ref #26477
also closes #26477 because it's the last PR in the issue