Repository navigation
test(tanstackstart-react): Add CSRF middleware to the e2e fixtures - #26451
Merged
Merged
Conversation
TanStack Start only installs CSRF protection for server functions when the app has no `start.ts`. Our setup needs one for the Sentry middleware. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Member
Author
|
bugbot run |
Contributor
size-limit report 📦Compared: c1e5e9f (PR test merge using develop at 6bd0415) Against: 6bd0415 (develop) · base run #66387 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 2 successful. See the run. |
…er function Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Member
Author
|
bugler zah an |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f0551de. Configure here.
s1gr1d
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The TanStack Start e2e apps now install TanStack Start's CSRF middleware in
start.ts. A new test checks that a cross-site server function request is blocked, while same-origin server function calls and server routes still work.Why
TanStack Start only installs CSRF protection for server functions when the app has no
start.ts. Our setup needs astart.tsfor the Sentry middleware, so our fixtures and examples ran without it. Part of #26022.