Repository navigation
Conversation
…om overwriting sourcemaps
URL.protocol always includes a trailing colon (e.g. 'https:') but the
OpenTelemetry url.scheme semantic convention specifies just the scheme
without the colon (e.g. 'https').
packages/browser-utils already stripped the colon correctly with an
explicit comment. Apply the same .replace(':', '') in the two remaining
sites that assigned protocol directly: getHttpSpanDetailsFromUrlObject
in packages/core and the Bun server integration.
Update the 18 test assertions that were written to match the wrong value.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL.protocolalways includes a trailing colon (e.g.'https:') but the OpenTelemetryurl.schemesemantic convention specifies just the scheme without the colon (e.g.'https').packages/browser-utilsalready stripped the colon correctly inbrowserMetrics.tswith an explicit comment:packages/nodealso strips it correctly inundici-instrumentation.ts:The two remaining sites that assigned
urlObject.protocoldirectly —getHttpSpanDetailsFromUrlObjectinpackages/core/src/utils/url.tsand the Bun server integration — were left unpatched. This caused every HTTP span created via those paths to emit a malformedurl.schemevalue with a trailing colon.The fix applies the same
.replace(':', '')in both locations and updates the 18 test assertions that expected the wrong value.