Repository navigation
perf(ci): Benchmark browser integration tests on ARM #26434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ concurrency: | |
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| HEAD_COMMIT: ${{ github.event.inputs.commit || github.sha }} | ||
| HEAD_COMMIT: ${{ github.event.inputs.commit || github.event.pull_request.head.sha || github.sha }} | ||
|
|
||
| CACHED_DEPENDENCY_PATHS: | | ||
| ${{ github.workspace }}/node_modules | ||
|
|
@@ -592,7 +592,7 @@ jobs: | |
| matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests | ||
| needs: [job_get_metadata, job_build] | ||
| if: needs.job_build.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request' | ||
| runs-on: ubuntu-24.04-large-js | ||
| runs-on: ubuntu-24.04-arm | ||
| timeout-minutes: 25 | ||
| strategy: | ||
| fail-fast: false | ||
|
|
@@ -690,6 +690,16 @@ jobs: | |
| name: build-bundle-output | ||
| path: ${{ env.BUNDLE_ARTIFACT_DOWNLOAD_PATH }} | ||
|
|
||
| - name: Record browser benchmark hardware | ||
| working-directory: dev-packages/browser-integration-tests | ||
| run: | | ||
| node -e ' | ||
| const os = require("node:os"); | ||
| const info = { arch: process.arch, cores: os.availableParallelism(), cpu: os.cpus()[0].model, memoryBytes: os.totalmem() }; | ||
| require("node:fs").writeFileSync("browser-runner.json", JSON.stringify(info)); | ||
| console.log(info); | ||
| ' | ||
|
|
||
| - name: Install Playwright | ||
| uses: ./.github/actions/install-playwright | ||
| with: | ||
|
|
@@ -704,6 +714,16 @@ jobs: | |
| pnpm run test:all${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && | ||
| format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }} | ||
|
|
||
| - name: Upload browser benchmark results | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: browser-benchmark-${{ matrix.bundle }}-${{ matrix.project }}-${{ matrix.shard || '0' }} | ||
| path: | | ||
| dev-packages/browser-integration-tests/results.junit.xml | ||
| dev-packages/browser-integration-tests/browser-runner.json | ||
| if-no-files-found: error | ||
|
|
||
| - name: Upload Playwright Traces | ||
| uses: actions/upload-artifact@v7 | ||
| if: failure() | ||
|
|
@@ -954,7 +974,7 @@ jobs: | |
| - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) | ||
| uses: actions/checkout@v7 | ||
| with: | ||
| ref: ${{ env.HEAD_COMMIT }} | ||
| ref: ${{ github.sha }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bundler tests checkout mismatches buildMedium Severity
Reviewed by Cursor Bugbot for commit e42696a. Configure here. |
||
| - name: Set up Node | ||
| uses: actions/setup-node@v7 | ||
| with: | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR CI checks out unmerged head
High Severity
HEAD_COMMITnow prefersgithub.event.pull_request.head.shaovergithub.sha, so PR jobs check out the branch tip instead of GitHub's merge commit.job_get_metadatastill receivesgithub.sha, and Nx affected compares that head againstpull_request.base.shafrom a pair of depth-1 checkouts. Those two commits usually do not share fetched ancestry, sogit merge-basecan fail and take downjob_buildfor multi-commit or out-of-date PRs. Even when it works, CI no longer tests the merged result.Additional Locations (1)
.github/workflows/build.yml#L106-L108Reviewed by Cursor Bugbot for commit e42696a. Configure here.