Repository navigation
test(ci): Benchmark natural splits of long integration suites #26420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nicohrubec
wants to merge
10
commits into
develop
Choose a base branch
from
feat/benchmark-split-node-ai-suites
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+826
−679
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
db3629f
test(ci): Capture baseline for integration suite file splits
nicohrubec 9252e89
test(ci): Align benchmark release SHA with checkout
nicohrubec 822e452
test(ci): Preserve bundler snapshot checkout convention
nicohrubec ee74352
test(node): Split Vercel AI integration tests by SDK version
nicohrubec b0a7750
test(node): Split Mastra tests by dependency group
nicohrubec e4de0c5
test(node): Split LangChain tracing and decision tests
nicohrubec edd5fe4
test(node): Split Express tracing and request-data tests
nicohrubec cd9ec06
test(node): Split OpenAI chat and other API tests
nicohrubec 6c90e70
test(node): Split Mastra agent and observability tests
nicohrubec 296a804
test(node): Separate Vercel AI streaming scenarios
nicohrubec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { mkdirSync, writeFileSync } from 'node:fs'; | ||
| import { dirname } from 'node:path'; | ||
| import type { Reporter, TestModule } from 'vitest/node'; | ||
|
|
||
| export default class BenchmarkReporter implements Reporter { | ||
| onTestRunEnd(modules: ReadonlyArray<TestModule>, errors: ReadonlyArray<unknown>, reason: string): void { | ||
| const path = process.env.INTEGRATION_TIMINGS; | ||
| if (!path) return; | ||
| mkdirSync(dirname(path), { recursive: true }); | ||
| writeFileSync( | ||
| path, | ||
| JSON.stringify( | ||
| { | ||
| source: process.env.HEAD_COMMIT, | ||
| node: process.version, | ||
| reason, | ||
| errors: errors.length, | ||
| files: modules.map(module => ({ | ||
| project: module.project.name, | ||
| file: module.relativeModuleId, | ||
| durationMs: module.diagnostic().duration, | ||
| collectMs: module.diagnostic().collectDuration, | ||
| state: module.state(), | ||
| tests: [...module.children.allTests()].map(test => ({ name: test.fullName, state: test.result().state })), | ||
| })), | ||
| }, | ||
| null, | ||
| 2, | ||
| ), | ||
| ); | ||
| } | ||
| } |
4 changes: 4 additions & 0 deletions
4
dev-packages/node-integration-tests/suites/express/tracing/request-data/test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import { describe } from 'vitest'; | ||
| import { registerExpressRequestDataTests } from '../suite'; | ||
|
|
||
| describe('express tracing', registerExpressRequestDataTests); |
4 changes: 4 additions & 0 deletions
4
dev-packages/node-integration-tests/suites/express/tracing/routing/test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import { describe } from 'vitest'; | ||
| import { registerExpressRoutingTests } from '../suite'; | ||
|
|
||
| describe('express tracing', registerExpressRoutingTests); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
dev-packages/node-integration-tests/suites/tracing/langchain/v1/decisions/test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import { describe } from 'vitest'; | ||
| import { registerLangChainDecisionTests } from '../suite'; | ||
|
|
||
| describe('LangChain integration (v1)', registerLangChainDecisionTests); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timing uploads omit overwrite
Low Severity
The new timing uploads omit
overwrite: true, which every otherupload-artifactstep in this workflow sets.if: always()already uploads after a failed attempt, so a job retry hits a duplicate-name error even if the tests then pass.Additional Locations (2)
.github/workflows/build.yml#L934-L942.github/workflows/build.yml#L1024-L1032Reviewed by Cursor Bugbot for commit db3629f. Configure here.