Repository navigation
ci: Don't count the PR's owners towards its required reviewers - #26417
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
The reviewer assignment counted reviews from the Junior requester and from NEVER_REQUEST managers, so commenting on your own Junior PR took a reviewer slot. Assignees now never count or get requested either. Co-Authored-By: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
Contributor
size-limit report 📦Compared: ad69024 (PR test merge using develop at e9d4584) Against: e9d4584 (develop) · base run #66248 ✅ Baseline matches: this diff contains only this PR's changes.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reviewer assignment no longer counts the author, the Junior requester, PR assignees, or the
NEVER_REQUESTmanagers towards the 3 required reviewers. This applies to both pending requests and submitted reviews. Assignees are also never picked as reviewers.Why
On #26413 only one reviewer was picked. The requester's own
COMMENTEDreviews counted as an existing reviewer, because the requester andNEVER_REQUESTchecks only applied to pending requests, not to reviews. People who own the PR comment on it while they work on it, and that isn't a review.via @mydea.
--
View Session [Sentry]