Skip to content

ci: Don't count the PR's owners towards its required reviewers - #26417

Open
sentry-junior[bot] wants to merge 1 commit into
developfrom
fix/reviewer-count-excludes-assignees
Open

sentry-junior[bot] wants to merge 1 commit into
developfrom
fix/reviewer-count-excludes-assignees

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

What

Reviewer assignment no longer counts the author, the Junior requester, PR assignees, or the NEVER_REQUEST managers towards the 3 required reviewers. This applies to both pending requests and submitted reviews. Assignees are also never picked as reviewers.

Why

On #26413 only one reviewer was picked. The requester's own COMMENTED reviews counted as an existing reviewer, because the requester and NEVER_REQUEST checks only applied to pending requests, not to reviews. People who own the PR comment on it while they work on it, and that isn't a review.

via @mydea.

--

View Session [Sentry]

The reviewer assignment counted reviews from the Junior requester and from
NEVER_REQUEST managers, so commenting on your own Junior PR took a reviewer
slot. Assignees now never count or get requested either.

Co-Authored-By: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: ad69024 (PR test merge using develop at e9d4584)

Against: e9d4584 (develop) · base run #66248

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.1 kB - -
@sentry/browser - with treeshaking flags 28.3 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.2 kB - -
@sentry/browser (incl. Tracing) 52.28 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.29 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.25 kB - -
@sentry/browser (incl. Tracing, Replay) 92.82 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.6 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.21 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.6 kB - -
@sentry/browser (incl. Feedback) 47.73 kB - -
@sentry/browser (incl. sendFeedback) 30.69 kB - -
@sentry/browser (incl. FeedbackAsync) 35.69 kB - -
@sentry/browser (incl. Metrics) 31.43 kB - -
@sentry/browser (incl. Logs) 31.71 kB - -
@sentry/browser (incl. Metrics & Logs) 32.37 kB - -
@sentry/react 32.11 kB - -
@sentry/react (incl. Tracing) 54.95 kB - -
@sentry/vue 38.3 kB - -
@sentry/vue (incl. Tracing) 55.24 kB - -
@sentry/svelte 30.12 kB - -
@sentry/remix (Remix 3 client bundle) 58.06 kB - -
CDN Bundle 31.87 kB - -
CDN Bundle (incl. Tracing) 52.7 kB - -
CDN Bundle (incl. Logs, Metrics) 34.67 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.26 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.7 kB - -
CDN Bundle (incl. Tracing, Replay) 90.72 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.33 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96.09 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.69 kB - -
CDN Bundle - uncompressed 92.98 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.45 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.33 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.08 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 231.44 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.61 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 283.24 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.02 kB - -
@sentry/nextjs (client) 58.37 kB - -
@sentry/sveltekit (client) 53.48 kB - -
@sentry/core/server 44.73 kB - -
@sentry/core/browser 14.3 kB - -
@sentry/node 151.23 kB -0.01% -4 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.3 kB - -
@sentry/node - without tracing 88.56 kB -0.01% -5 B 🔽
@sentry/node - without channel injection 140.17 kB -0.01% -7 B 🔽
@sentry/aws-serverless 98.91 kB -0.01% -4 B 🔽
@sentry/cloudflare (withSentry) - minified 205.88 kB - -
@sentry/cloudflare (withSentry) 477.87 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 231.06 kB - -

View base workflow run

@mydea
mydea marked this pull request as ready for review November 16, 2026 14:10
@mydea
mydea requested review from a team and JPeer264 November 16, 2026 14:10
@sentry-junior
sentry-junior Bot requested a review from mydea November 16, 2026 14:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant