Repository navigation
chore(ci): Route e2e test apps and more packages to SDK subteams in REVIEWERS - #26415
Open
sentry-junior[bot] wants to merge 3 commits into
Open
sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
…EVIEWERS Co-Authored-By: Francesco Gringl-Novy <2411343+mydea@users.noreply.github.com>
mydea
reviewed
Nov 16, 2026
mydea
reviewed
Nov 16, 2026
mydea
reviewed
Nov 16, 2026
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 62 successful. See the run.
Successful checks
|
Contributor
size-limit report 📦Compared: 839afd1 (PR test merge using develop at e9d4584) Against: e9d4584 (develop) · base run #66248 ✅ Baseline matches: this diff contains only this PR's changes.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PRs that only touch e2e test applications,
wasm,integration-shims,browser-min-version-tests, or the server- or browser-specific parts ofpackages/corenow get reviewers from the owning subteam instead of the whole team. Test apps map to a team by name prefix (nextjs-*goes to framework,node-*to server,browser-*to browser, and so on). A header comment also explains the fallback.Why
About a third of human commits on
developsince Aug 15 (455 of 1,358, a stand-in for PRs) touched only unrouted paths, mostly tests, so their reviewers were random picks from the whole team. With these rules that drops to 189. CI, scripts, root config, shared test utils, and the rest ofpackages/corestay unrouted on purpose. A catch-all*rule would put the whole team in every PR's pool and dilute the subteam routing.Open question: the bundler plugins (
packages/bundler-plugins,esbuild-/rollup-/vite-/webpack-plugin,bundler-plugin-integration-tests,bundler-tests,debug-id-sourcemaps) stay unrouted until someone decides who owns them.via @mydea.
--
View Session [Sentry]