Skip to content

ref(tanstackstart-react): Forward request options in the server entry example - #26408

Merged
chargome merged 1 commit into
developfrom
fix/tanstackstart-forward-request-opts
Nov 16, 2026
Merged

chargome merged 1 commit into
developfrom
fix/tanstackstart-forward-request-opts

Conversation

@chargome

Copy link
Copy Markdown
Member

What

The documented server entry now forwards TanStack Start's request options to the handler. The e2e fixtures use the same shape, and a new test checks that request context set in the server entry reaches a server route.

Why

Our example called handler.fetch(request) and dropped the second argument. TanStack Start reads the typed request context from it, so apps that copied our setup lost that context. Part of #26022.

… example

The documented server entry called `handler.fetch(request)` and dropped the
second argument. TanStack Start reads the typed request context from it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@chargome chargome self-assigned this Nov 16, 2026
@chargome

Copy link
Copy Markdown
Member Author

bugbot run

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 87aa365 (PR test merge using develop at f5131d1)

Against: f5131d1 (develop) · base run #66221

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.1 kB - -
@sentry/browser - with treeshaking flags 28.3 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.2 kB - -
@sentry/browser (incl. Tracing) 52.28 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.29 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.25 kB - -
@sentry/browser (incl. Tracing, Replay) 92.82 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.6 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.21 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.6 kB - -
@sentry/browser (incl. Feedback) 47.73 kB - -
@sentry/browser (incl. sendFeedback) 30.69 kB - -
@sentry/browser (incl. FeedbackAsync) 35.69 kB - -
@sentry/browser (incl. Metrics) 31.43 kB - -
@sentry/browser (incl. Logs) 31.71 kB - -
@sentry/browser (incl. Metrics & Logs) 32.37 kB - -
@sentry/react 32.11 kB - -
@sentry/react (incl. Tracing) 54.95 kB - -
@sentry/vue 38.3 kB - -
@sentry/vue (incl. Tracing) 55.24 kB - -
@sentry/svelte 30.12 kB - -
@sentry/remix (Remix 3 client bundle) 58.06 kB - -
CDN Bundle 31.87 kB - -
CDN Bundle (incl. Tracing) 52.7 kB - -
CDN Bundle (incl. Logs, Metrics) 34.67 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.26 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.7 kB - -
CDN Bundle (incl. Tracing, Replay) 90.72 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.33 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96.09 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.69 kB - -
CDN Bundle - uncompressed 92.98 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.45 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.33 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.08 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 231.44 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.61 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 283.24 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.02 kB - -
@sentry/nextjs (client) 58.37 kB - -
@sentry/sveltekit (client) 53.48 kB - -
@sentry/core/server 44.73 kB - -
@sentry/core/browser 14.3 kB - -
@sentry/node 150.67 kB -0.01% -6 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.3 kB - -
@sentry/node - without tracing 88.55 kB -0.01% -5 B 🔽
@sentry/node - without channel injection 139.62 kB -0.01% -6 B 🔽
@sentry/aws-serverless 98.46 kB -0.01% -4 B 🔽
@sentry/cloudflare (withSentry) - minified 205.82 kB - -
@sentry/cloudflare (withSentry) 477.65 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 231 kB - -

View base workflow run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit e1510ce. Configure here.

@mydea

mydea commented Nov 16, 2026

Copy link
Copy Markdown
Member

probably rather a "chore", "ref" or "docs" topic? 🤔

@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

All optional checks were successful. 3 successful. See the run.

Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 44s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 32s Details

@chargome
chargome marked this pull request as ready for review November 16, 2026 14:42
@chargome
chargome requested review from a team and JPeer264 November 16, 2026 14:42
@chargome chargome changed the title fix(tanstackstart-react): Forward request options in the server entry example ref(tanstackstart-react): Forward request options in the server entry example Nov 16, 2026
@chargome
chargome merged commit 54747d0 into develop Nov 16, 2026
58 checks passed
@chargome
chargome deleted the fix/tanstackstart-forward-request-opts branch November 16, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants