Repository navigation
ref(tanstackstart-react): Forward request options in the server entry example - #26408
Merged
Merged
Conversation
… example The documented server entry called `handler.fetch(request)` and dropped the second argument. TanStack Start reads the typed request context from it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Member
Author
|
bugbot run |
Contributor
size-limit report 📦Compared: 87aa365 (PR test merge using develop at f5131d1) Against: f5131d1 (develop) · base run #66221 ✅ Baseline matches: this diff contains only this PR's changes.
|
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e1510ce. Configure here.
Member
|
probably rather a "chore", "ref" or "docs" topic? 🤔 |
Contributor
Optional E2E testsAll optional checks were successful. 3 successful. See the run. Successful checks
|
chargome
marked this pull request as ready for review
November 16, 2026 14:42
nicohrubec
approved these changes
Nov 16, 2026
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The documented server entry now forwards TanStack Start's request options to the handler. The e2e fixtures use the same shape, and a new test checks that request context set in the server entry reaches a server route.
Why
Our example called
handler.fetch(request)and dropped the second argument. TanStack Start reads the typed request context from it, so apps that copied our setup lost that context. Part of #26022.