Repository navigation
fix(bundler-plugins): Inject debug IDs into every esbuild rebuild - #26099
Merged
Merged
Conversation
timfish
marked this pull request as ready for review
November 4, 2026 12:37
timfish
requested review from
Lms24,
andreiborza,
isaacs,
logaretm,
mydea and
s1gr1d
and removed request for
a team
November 4, 2026 12:37
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 43 successful. See the run.
Successful checks
|
Contributor
size-limit report 📦Compared: 9b5e59a (PR test merge using develop at bbec9a0) Against: bbec9a0 (develop) · base run #64978 ✅ Baseline matches: this diff contains only this PR's changes.
|
mydea
approved these changes
Nov 4, 2026
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The esbuild plugin cleared its set of wrapped entry points in
setup, which esbuild runs once per context. Oncontext().rebuild()and in watch mode, every entry point after the first build counted as already wrapped, so the rebuilt bundles carried no debug ID and the upload warned that no source maps were found. The reset now runs in anonStarthook, once per build.Found while reviewing #25648, where the missing debug IDs also kept the plugin from cleaning up the maps it had turned on.
Fixes #26098