Skip to content

ref(server-utils): Share one cron converter across cron integrations - #25918

Merged
wedamija merged 22 commits into
developfrom
danf/shared-cron-converter
Nov 16, 2026
Merged

wedamija merged 22 commits into
developfrom
danf/shared-cron-converter

Conversation

@wedamija

@wedamija wedamija commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.

isaacs asked in review of #25013 for one cron converter, so @SentryCron, Sentry.cron.* and the scheduler integrations read schedules the same way and can't drift apart. They now all use one converter in @sentry/server-utils, which takes the scheduler's dialect (node-cron, cron or cron-parser), since they read day fields, names and nicknames differently.

For Sentry.cron.instrumentCron, instrumentNodeCron and instrumentNodeSchedule, this means: without a time zone, they send the server's time zone instead of letting Sentry assume UTC. Expressions Sentry would read differently than the scheduler, like per-second schedules or 0 9 31 2,4 *, send no monitor config, so existing monitors keep their schedule.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants