Repository navigation
feat(bundler-plugins): Enable hidden source maps and remove them after upload in the Vite plugin - #25646
Open
timfish wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦Compared: 100a68b (PR test merge using develop at 3357465) Against: 9310b4d (develop) · base run #64276
|
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 22, 2026 10:57
ac0df2a to
6546bd8
Compare
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 55 successful. See the run.
Successful checks
|
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 22, 2026 11:49
6546bd8 to
30717e0
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 27, 2026 16:25
30717e0 to
f2ee9aa
Compare
timfish
marked this pull request as ready for review
October 27, 2026 18:01
timfish
requested review from
chargome and
nicohrubec
and removed request for
a team
October 27, 2026 18:01
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 28, 2026 12:15
f2ee9aa to
9d1b219
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 28, 2026 12:24
9d1b219 to
4f7189e
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 28, 2026 12:54
4f7189e to
8469e6d
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 29, 2026 11:59
a0b6719 to
e9fb9ac
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 29, 2026 12:16
e9fb9ac to
7047dc0
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 29, 2026 13:42
7047dc0 to
9f8b785
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 29, 2026 14:54
9f8b785 to
2e4c2ee
Compare
timfish
enabled stacked auto-merge (squash)
October 29, 2026 15:25
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 29, 2026 17:06
2e4c2ee to
f8dc498
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
2 times, most recently
from
October 29, 2026 17:15
2beac82 to
d07dc27
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 29, 2026 17:39
d07dc27 to
47ac301
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 29, 2026 20:54
47ac301 to
8aacc02
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 29, 2026 21:36
8aacc02 to
06117c3
Compare
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 29, 2026 21:59
06117c3 to
b4b8cfd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b4b8cfd. Configure here.
|
|
||
| const environmentKind = sourceMapKindFromRollupSetting(setting); | ||
| const environmentDecision = sentryBuildPluginManager.sourceMaps.decide(environmentKind); | ||
| decisions.set(name, { kind: environmentKind, decision: environmentDecision }); |
There was a problem hiding this comment.
Stale environment decisions across builds
Low Severity
The decisions map is never cleared when config runs. Reusing the same plugin instances, which the client-then-SSR path does, keeps named environment entries from the previous config. A later build then applies those stale decisions if the environment no longer sets sourcemap itself.
Reviewed by Cursor Bugbot for commit b4b8cfd. Configure here.
…r upload in the Vite plugin The Vite plugin decides on `build.sourcemap` in its `config` hook, because Vite warns about `rollupOptions.output.sourcemap`, and maps the decision onto each environment's output directory in `configResolved`. The post plugin that restores debug IDs for `disable-upload` builds is now always present and also stages the source maps for upload.
timfish
force-pushed
the
feat/bundler-plugins-delete-sourcemaps-vite
branch
from
October 29, 2026 22:25
b4b8cfd to
7196d7f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the stack for #25609. Vite warns about
rollupOptions.output.sourcemap, so the Vite plugin decides onbuild.sourcemapin aconfighook on the post plugin, which runs after framework plugins that setbuild.sourcemapthemselves.configResolvedthen records one decision per output ofrollupOptions.outputand per Vite 6 environment, and the shared RollupgenerateBundlehook does the staging. An output or environment that setssourcemapitself is never changed; only hidden maps the user asked to delete are removed there.A client build and an SSR build of the same plugin instances stage on their own, keyed by output directory. Builds with
build.write: falsedo not create a staging folder. Integration fixtures coversourcemaps.ignoreandsourcemaps.assetson the staged path for Vite 8.