Repository navigation
Conversation
logaretm
added this pull request to stack #25201
October 15, 2026 15:33
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
2 times, most recently
from
October 15, 2026 15:36
364f99c to
b6212f2
Compare
Contributor
size-limit report 📦Compared: 0823bbc (PR test merge using develop at 12757d0) Against: ca4fc32 (develop) · base run #62950
|
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
2 times, most recently
from
October 15, 2026 16:20
de28310 to
47c1f76
Compare
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
from
October 15, 2026 16:38
47c1f76 to
d1a7e32
Compare
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
from
October 15, 2026 17:15
d1a7e32 to
17f5b0c
Compare
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
from
October 15, 2026 17:36
17f5b0c to
ff9f3cc
Compare
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
2 times, most recently
from
October 15, 2026 18:16
7185904 to
0846a80
Compare
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
from
October 15, 2026 18:26
0846a80 to
2d31aba
Compare
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
from
October 15, 2026 18:28
2d31aba to
d7b1800
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
from
October 16, 2026 01:51
d7b1800 to
1d49365
Compare
Member
Author
|
bugbot run |
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
from
October 16, 2026 02:25
1d49365 to
89e93d5
Compare
Member
Author
|
bugbot run |
logaretm
force-pushed
the
awad/tunnel-sveltekit
branch
from
October 19, 2026 19:12
05c691a to
36f589a
Compare
logaretm
marked this pull request as ready for review
October 19, 2026 19:36
logaretm
requested review from
chargome and
s1gr1d
and removed request for
a team
October 19, 2026 19:36
logaretm
requested review from
JPeer264 and
isaacs
and removed request for
a team
October 19, 2026 20:08
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5cbcc07. Configure here.
Contributor
|
One or more gzipped bundles increased by more than 500 bytes. If this increase is intentional, add the Accept Bundlesize Increase label to this PR to rerun and accept the check. |
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 failing, 58 successful. See the run.
Successful checks
|
Contributor
Lms24
reviewed
Oct 23, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Nice! Just had one question about the base path plugin. Once that's resolved, good to merge! Handling tunnel requests directly via our sentryHandle handler seems fine to me.
I guess a future improvement could be to add an option in our sentrySveltekit plugin that auto-enables the managed tunnel on client and server (somewhat similar to the one-option tunnelRoute approach in NextJS) so that users don't have to configure it in two places. But totally fine with not doing this for the moment. In agentic times we might not even need this.
| environment: 'qa', | ||
| dsn: PUBLIC_E2E_TEST_DSN, | ||
| tunnel: 'http://localhost:3031/', // proxy server | ||
| tunnel: __E2E_TEST_TUNNEL__ ? true : 'http://localhost:3031/', // proxy server |
Member
There was a problem hiding this comment.
super-l: Can we import the env variable instead of the build time transform? Basically like for E2E_TEST_DSN?
| dsn: E2E_TEST_DSN, | ||
| debug: !!process.env.DEBUG, | ||
| tunnel: 'http://localhost:3031/', // proxy server | ||
| tunnel: __E2E_TEST_TUNNEL__ ? true : 'http://localhost:3031/', // proxy server |
Member
There was a problem hiding this comment.
m/q: can we use makeGlobalValuesInjectionPlugin instead? This should already have the kit config and it already injects other global values. Might be missing a reason though why this plugin makes more sense standalone
…he app's base path `sentryHandle` answers tunnel requests before isolation, tracing and routing. `sentrySvelteKit()` hands `paths.base` to the client and server SDKs, so `tunnel: true` works under a base path without repeating it.
The tunnel handler now answers a request without one with a 411.
…, in one test per app
…ests of what the SDK adds
…dules as side-effect free
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements sveltekit tunnel wiring, the way it works is:
kit.paths.base) if it exists to both server/client bundles.sentryHandle) will check for any incoming request if it is a tunneled one, and if it matches it handles it.(I made the decision to respect base paths rather than ignoring them, this is something to review in #25199)
This also adds a couple of shared e2e helpers to
@sentry-internal/test-utilsthat the rest of the stack uses. Thesveltekit-3tunnel variants cover dev and prod, and there's one for Cloudflare Workers too.For reviewers: if you need an overview of what this is, refer to #25199.
closes #20256