test(node): port rejection, feature flag, and client-report tests to span streaming

dev-packages/node-integration-tests/suites/client-reports/drop-reasons/before-send/scenario.ts

@@ -4,7 +4,6 @@ import { loggingTransport } from '@sentry-internal/node-integration-tests';
 // eslint-disable-next-line @typescript-eslint/no-floating-promises
 (async () => {
   Sentry.init({
-    traceLifecycle: 'static',
     dsn: 'https://public@dsn.ingest.sentry.io/1337',
     transport: loggingTransport,
     beforeSend(event) {

dev-packages/node-integration-tests/suites/client-reports/drop-reasons/event-processor-throws/scenario-async.ts

@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
 import { loggingTransport } from '@sentry-internal/node-integration-tests';
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   transport: loggingTransport,
 });

dev-packages/node-integration-tests/suites/client-reports/drop-reasons/event-processors/scenario.ts

@@ -4,7 +4,6 @@ import { loggingTransport } from '@sentry-internal/node-integration-tests';
 // eslint-disable-next-line @typescript-eslint/no-floating-promises
 (async () => {
   Sentry.init({
-    traceLifecycle: 'static',
     dsn: 'https://public@dsn.ingest.sentry.io/1337',
     transport: loggingTransport,
   });

dev-packages/node-integration-tests/suites/client-reports/drop-reasons/traces-sampler-throws/scenario-fallback.ts

@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
 import { loggingTransport } from '@sentry-internal/node-integration-tests';
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   transport: loggingTransport,
   tracesSampleRate: 1,

dev-packages/node-integration-tests/suites/client-reports/drop-reasons/traces-sampler-throws/test.ts

@@ -1,4 +1,4 @@
-import { afterAll, test } from 'vitest';
+import { afterAll, expect, test } from 'vitest';
 import { cleanupChildProcesses, createRunner } from '../../../../utils/runner';
 
 afterAll(() => {
@@ -25,9 +25,11 @@ test('records a client report and no error event when tracesSampler throws', asy
 
 test('sends the span when tracesSampler throws but tracesSampleRate is 1', async () => {
   await createRunner(__dirname, 'scenario-fallback.ts')
+    .unordered()
     .expect({
-      transaction: {
-        transaction: 'sampled via tracesSampleRate fallback',
+      span: container => {
+        const segment = container.items.find(span => span.is_segment);
+        expect(segment?.name).toBe('sampled via tracesSampleRate fallback');
       },
     })
     .start()

dev-packages/node-integration-tests/suites/featureFlags/featureFlagsIntegration/onSpan/scenario.ts

@@ -3,7 +3,6 @@ import * as Sentry from '@sentry/node';
 import { loggingTransport } from '@sentry-internal/node-integration-tests';
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   sampleRate: 1.0,
   tracesSampleRate: 1.0,

dev-packages/node-integration-tests/suites/featureFlags/featureFlagsIntegration/onSpan/test.ts

@@ -1,4 +1,4 @@
-import { _INTERNAL_MAX_FLAGS_PER_SPAN as MAX_FLAGS_PER_SPAN } from '@sentry/core';
+import { _INTERNAL_MAX_FLAGS_PER_SPAN as MAX_FLAGS_PER_SPAN, type SerializedStreamedSpanContainer } from '@sentry/core';
 import { afterAll, expect, test } from 'vitest';
 import { cleanupChildProcesses, createRunner } from '../../../../utils/runner';
 
@@ -8,24 +8,31 @@ afterAll(() => {
 
 test('Flags captured on span attributes with max limit', async () => {
   // Based on scenario.ts.
-  const expectedFlags: Record<string, boolean> = {};
+  const expectedFlags: Record<string, { type: 'boolean'; value: boolean }> = {};
   for (let i = 1; i <= MAX_FLAGS_PER_SPAN; i++) {
-    expectedFlags[`flag.evaluation.feat${i}`] = i === 3;
+    expectedFlags[`flag.evaluation.feat${i}`] = { type: 'boolean', value: i === 3 };
   }
+  const spans: SerializedStreamedSpanContainer['items'] = [];
 
   await createRunner(__dirname, 'scenario.ts')
+    .unordered()
     .expect({
-      transaction: {
-        spans: [
-          expect.objectContaining({
-            description: 'test-span',
-            data: expect.objectContaining({}),
-          }),
-          expect.objectContaining({
-            description: 'test-nested-span',
-            data: expect.objectContaining(expectedFlags),
-          }),
-        ],
+      span: container => {
+        spans.push(...container.items);
+        const children = spans.filter(span => !span.is_segment);
+        expect(children).toHaveLength(2);
+        expect(children).toEqual(
+          expect.arrayContaining([
+            expect.objectContaining({
+              name: 'test-span',
+              attributes: expect.objectContaining({}),
+            }),
+            expect.objectContaining({
+              name: 'test-nested-span',
+              attributes: expect.objectContaining(expectedFlags),
+            }),
+          ]),
+        );
       },
     })
     .start()

dev-packages/node-integration-tests/suites/featureFlags/growthbook/onSpan/scenario.ts

@@ -44,7 +44,6 @@ class GrowthBookWrapper {
 const gb = new GrowthBookWrapper();
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   sampleRate: 1.0,
   tracesSampleRate: 1.0,

dev-packages/node-integration-tests/suites/featureFlags/growthbook/onSpan/test.ts

@@ -7,26 +7,26 @@ afterAll(() => {
 
 test('GrowthBook flags are added to active span attributes on span end', async () => {
   await createRunner(__dirname, 'scenario.ts')
+    .unordered()
     .expect({
-      transaction: {
-        contexts: {
-          trace: {
-            data: {
-              'flag.evaluation.feat1': true,
-              'flag.evaluation.feat2': false,
-              'flag.evaluation.bool-feat': true,
-              // string-feat should NOT be here since it's not boolean
-            },
-            op: 'function',
-            origin: 'manual',
-            status: 'ok',
-            span_id: expect.stringMatching(/[a-f\d]{16}/),
-            trace_id: expect.stringMatching(/[a-f\d]{32}/),
+      span: container => {
+        expect(container.items).toHaveLength(1);
+        const span = container.items.find(item => item.is_segment);
+        expect(span).toMatchObject({
+          name: 'test-span',
+          status: 'ok',
+          span_id: expect.stringMatching(/[a-f\d]{16}/),
+          trace_id: expect.stringMatching(/[a-f\d]{32}/),
+          attributes: {
+            'flag.evaluation.feat1': { type: 'boolean', value: true },
+            'flag.evaluation.feat2': { type: 'boolean', value: false },
+            'flag.evaluation.bool-feat': { type: 'boolean', value: true },
+            'sentry.op': { type: 'string', value: 'function' },
+            'sentry.origin': { type: 'string', value: 'manual' },
           },
-        },
-        spans: [],
-        transaction: 'test-span',
-        type: 'transaction',
+        });
+        // string-feat should NOT be here since it's not boolean
+        expect(span?.attributes['flag.evaluation.string-feat']).toBeUndefined();
       },
     })
     .start()

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/ignore-custom-name.js

@@ -2,7 +2,6 @@ const Sentry = require('@sentry/node');
 const { expectProcessToExit } = require('../../../utils/expect-process-to-exit');
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   integrations: [
     Sentry.onUnhandledRejectionIntegration({

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/ignore-default.js

@@ -2,7 +2,6 @@ const Sentry = require('@sentry/node');
 const { expectProcessToExit } = require('../../../utils/expect-process-to-exit');
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   // Use default mode: 'warn' - integration is active but should ignore AI_NoOutputGeneratedError
 });

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/mode-none.js

@@ -2,7 +2,6 @@ const Sentry = require('@sentry/node');
 const { expectProcessToExit } = require('../../../utils/expect-process-to-exit');
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'none' })],
 });

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/mode-strict.js

@@ -2,7 +2,6 @@ const Sentry = require('@sentry/node');
 const { expectProcessToExit } = require('../../../utils/expect-process-to-exit');
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
 });

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/mode-warn-error.js

@@ -2,7 +2,6 @@ const Sentry = require('@sentry/node');
 const { expectProcessToExit } = require('../../../utils/expect-process-to-exit');
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
 });
 

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/mode-warn-string.js

@@ -2,7 +2,6 @@ const Sentry = require('@sentry/node');
 const { expectProcessToExit } = require('../../../utils/expect-process-to-exit');
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
 });
 

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/scenario-strict.ts

@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
 import { loggingTransport } from '@sentry-internal/node-integration-tests';
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   release: '1.0',
   transport: loggingTransport,

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/scenario-warn.ts

@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
 import { loggingTransport } from '@sentry-internal/node-integration-tests';
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   release: '1.0',
   transport: loggingTransport,

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/scenario-with-span-ended.ts

@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
 import { loggingTransport } from '@sentry-internal/node-integration-tests';
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   release: '1.0',
   tracesSampleRate: 1,

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/scenario-with-span.ts

@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
 import { loggingTransport } from '@sentry-internal/node-integration-tests';
 
 Sentry.init({
-  traceLifecycle: 'static',
   dsn: 'https://public@dsn.ingest.sentry.io/1337',
   release: '1.0',
   tracesSampleRate: 1,

dev-packages/node-integration-tests/suites/public-api/onUnhandledRejectionIntegration/test.ts

@@ -1,4 +1,4 @@
-import type { Event } from '@sentry/node';
+import type { Event, SerializedStreamedSpanContainer } from '@sentry/node';
 import * as childProcess from 'child_process';
 import * as path from 'path';
 import { afterAll, describe, expect, test } from 'vitest';
@@ -142,15 +142,16 @@ test rejection`);
       .completed();
   });
 
-  // Bun: the error event arrives before the transaction, or has a different span id.
-  test.skipIf(RUNTIME === 'bun')('handles unhandled rejection in spans', async () => {
-    let transactionEvent: Event | undefined;
+  test('handles unhandled rejection in spans', async () => {
+    let segment: SerializedStreamedSpanContainer['items'][number] | undefined;
     let errorEvent: Event | undefined;
 
     await createRunner(__dirname, 'scenario-with-span.ts')
+      .unordered()
       .expect({
-        transaction: transaction => {
-          transactionEvent = transaction;
+        span: container => {
+          segment = container.items.find(span => span.is_segment);
+          expect(segment?.name).toBe('test-span');
         },
       })
       .expect({
@@ -161,23 +162,24 @@ test rejection`);
       .start()
       .completed();
 
-    expect(transactionEvent).toBeDefined();
+    expect(segment).toBeDefined();
     expect(errorEvent).toBeDefined();
 
-    expect(transactionEvent!.transaction).toBe('test-span');
-
-    expect(transactionEvent!.contexts!.trace!.trace_id).toBe(errorEvent!.contexts!.trace!.trace_id);
-    expect(transactionEvent!.contexts!.trace!.span_id).toBe(errorEvent!.contexts!.trace!.span_id);
+    expect(segment!.trace_id).toBe(errorEvent!.contexts!.trace!.trace_id);
+    expect(segment!.span_id).toBe(errorEvent!.contexts!.trace!.span_id);
   });
 
+  // Bun: the rejection event's span ID differs from the already-ended span's ID.
   test.skipIf(RUNTIME === 'bun')('handles unhandled rejection in spans that are ended early', async () => {
-    let transactionEvent: Event | undefined;
+    let segment: SerializedStreamedSpanContainer['items'][number] | undefined;
     let errorEvent: Event | undefined;
 
     await createRunner(__dirname, 'scenario-with-span-ended.ts')
+      .unordered()
       .expect({
-        transaction: transaction => {
-          transactionEvent = transaction;
+        span: container => {
+          segment = container.items.find(span => span.is_segment);
+          expect(segment?.name).toBe('test-span');
         },
       })
       .expect({
@@ -188,13 +190,11 @@ test rejection`);
       .start()
       .completed();
 
-    expect(transactionEvent).toBeDefined();
+    expect(segment).toBeDefined();
     expect(errorEvent).toBeDefined();
 
-    expect(transactionEvent!.transaction).toBe('test-span');
-
-    expect(transactionEvent!.contexts!.trace!.trace_id).toBe(errorEvent!.contexts!.trace!.trace_id);
-    expect(transactionEvent!.contexts!.trace!.span_id).toBe(errorEvent!.contexts!.trace!.span_id);
+    expect(segment!.trace_id).toBe(errorEvent!.contexts!.trace!.trace_id);
+    expect(segment!.span_id).toBe(errorEvent!.contexts!.trace!.span_id);
   });
 
   test('should not warn when AI_NoOutputGeneratedError or AbortError is rejected (default ignore)', () =>