test(e2e): Add trace test for background use cache revalidation - #24740
Merged
Merged
Conversation
s1gr1d
requested review from
chargome and
cvxluo
and removed request for
cvxluo
September 25, 2026 12:11
Contributor
size-limit report 📦
|
chargome
reviewed
Sep 25, 2026
chargome
left a comment
chargome
left a comment
Member
There was a problem hiding this comment.
Bit hard to follow what this actually does, tests are also failing?
| import { CACHE_ORIGIN_LINK_ATTRIBUTES, findCacheSpan } from './cacheOriginLinks-utils'; | ||
|
|
||
| // Background stale-while-revalidate refills. Target behavior: the revalidation runs in its own | ||
| // trace (not grafted onto the serving trace), links back to the request that triggered it, and |
Member
Author
|
I improved the comments a bit and also added the ASCII trace so it's easier to follow :D |
chargome
approved these changes
Sep 30, 2026
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test for background stale-while-revalidate refills of
use cacheentries. Target behavior: the refill runs in its own trace, not as part of the trace that served the stale value. The refill trace links back to the request that triggered it and becomes thecache_originfor future hits.The behavior is not implemented yet. The test is
test.fixme(), nottest.fail(): it waits for acache.revalidatetrace that never arrives, so it would hit the test timeout — and Playwright reports a timeout as a real failure even undertest.fail(). Production only — the SWR timing does not hold on the dev server.Closes #24732
Linear https://linear.app/getsentry/issue/JS-3805/trace-test-for-background-use-cache-revalidation