Conversation
Contributor
size-limit report 📦
|
…table capture flag Fixes #24702 Co-Authored-By: Cursor Agent <cursoragent@cursor.com> Co-authored-by: lamberto <macuzi@users.noreply.github.com>
Lms24
force-pushed
the
cursor/dom-click-listener-leak-565e
branch
from
September 25, 2026 08:45
76613ce to
ca9ded4
Compare
Member
|
this went into the right direction but needed some further fixes to account for ref count differentiates. I'd like to get this reviewed, so I opened #24727. Thanks though! |
Lms24
added a commit
that referenced
this pull request
Sep 30, 2026
…matched removals (#24727) This PR fixes two (related) problems in our `instrumentDOM` event listener instrumentation: TIL about event listener [capture](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#usecapture) modes. 1. We didn't differentiate between `addEventListener(fn, {capture: true})` and `addEventListener(fn, {capture: false})` calls, causing leakage of our event listeners when event listeners were removed with different options. => Fixed by checking the `capture` option, registering our own listeners in the same capture config and keeping the capture option on the meta object of the event target so that we can then remove it in the correct capture config 2. More generally fixes an issue with `refCount` where e.g. calling `removeEventListener` with a callback that was never added via `addEventListener`: Browsers just ignore this call but our refCount was decremented anyway. => Fixed by replacing the general ref count with two sets of callbacks (for both capture modes) and only removing our listener if all user-set listeners were removed Fixes #24702 supersedes #24725 supersedes #24723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instrumentDOMregistered its per-target handler with whateveraddEventListeneroptions the first caller used, but removed it with the options from whicheverremoveEventListenerdrove the refcount to zero. Radix DismissableLayer can decrement the refcount via bubble-phase no-op removals while the handler was added in capture phase, so the real listener was never removed and leaked on every dialog cycle.Store the capture flag when attaching and always use it when detaching.
Fixes #24702