Conversation
Co-Authored-By: OpenAI GPT-5 <codex@openai.com>
DorianChn
marked this pull request as ready for review
September 25, 2026 03:05
DorianChn
requested review from
logaretm and
msonnb
and removed request for
a team
September 25, 2026 03:05
|
Hi @DorianChn , I independently tested your All 33 jsdom cases and four Chromium tests pass. The browser tests cover the 20-cycle document-listener leak and missing I have two browser integration suites ready to contribute. Would you prefer to include them in this PR or have a tests-only follow-up after it merges? Tested locally with Node 22.22.1 and Chromium |
Member
|
Thanks for contributing! unfortunately this is too large and not a minimal fix (see #24727). |
Lms24
added a commit
that referenced
this pull request
Sep 30, 2026
…matched removals (#24727) This PR fixes two (related) problems in our `instrumentDOM` event listener instrumentation: TIL about event listener [capture](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#usecapture) modes. 1. We didn't differentiate between `addEventListener(fn, {capture: true})` and `addEventListener(fn, {capture: false})` calls, causing leakage of our event listeners when event listeners were removed with different options. => Fixed by checking the `capture` option, registering our own listeners in the same capture config and keeping the capture option on the meta object of the event target so that we can then remove it in the correct capture config 2. More generally fixes an issue with `refCount` where e.g. calling `removeEventListener` with a callback that was never added via `addEventListener`: Browsers just ignore this call but our refCount was decremented anyway. => Fixed by replacing the general ref count with two sets of callbacks (for both capture modes) and only removing our listener if all user-set listeners were removed Fixes #24702 supersedes #24725 supersedes #24723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DOM instrumentation wrapper currently decrements its refcount for every removeEventListener call, including no-op removals. When a capture-phase listener is the first registration, a later bubble-phase no-op removal can reach zero with the wrong capture mode and leave the internal handler attached.
Why: Track actual listener/capture registrations and normalize the internal handler to a stable capture boolean. This prevents unrelated removals from dropping the bookkeeping early and preserves correct cleanup when multiple listeners use different capture modes.
Fixes #24702
Validation: The targeted DOM regression test, browser-utils build, package lint, type-aware lint, targeted format check, and git diff checks pass. The package-wide test run reached 251/252; its only failure was the unrelated networkUtils Request/URLSearchParams mismatch in this local jsdom environment.