feat(node): Support Prisma 8 in `prismaIntegration` by chargome · Pull Request #24682 · getsentry/sentry-javascript

chargome · 2026-09-24T09:07:27Z

Wraps Prisma 8's ORM terminals via orchestrion: each ORM call gets a prisma:client:operation span (sentry.op: db, db.operation.name, db.collection.name, plus v7's method/model/name) with the pg query spans nested underneath. No user code needed.

Patch point is CollectionImpl in the transitive @prisma/orm-family-sql, pinned >=8.0.0-rc.8 <9; verified on rc.8.
Lazy terminals (all, createAll, updateAll, deleteAll) return a single-use thenable that orchestrion's promise wrapper would consume, so they're wrapped Sync and the subscriber hooks consumption instead.
Nested terminal calls reuse the outer span. Operation spans require a parent.
CJS apps on Node 20 keep pg-only spans, since require(esm) bypasses the module hooks there. From Node 22 on they're covered; with the async hooks (before Node 24.13 / 25.1) a call in the same tick as the require runs before the SDK subscribes. ESM apps are fully covered.

Fixes #24237

chargome · 2026-09-24T09:08:08Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

cursor · 2026-09-24T09:12:15Z

+        end(error);
+        return Promise.reject(error);
+      }
+      return settle(runUnderSpan(span, () => iterator.throw!(error)));


Uncommented non-null assertions

Low Severity

iterator.return! and iterator.throw! are non-null assertions with no comment on why a narrower type is not possible. Flagged because the review rules require that explanation on new ! assertions in SDK source.

Additional Locations (1)

packages/server-utils/src/integrations/prisma/orchestrion.ts#L185-L189

^{Triggered by project rule: PR Review Guidelines for Cursor Bot}

^{Reviewed by Cursor Bugbot for commit 4e7097b. Configure here.}

github-actions · 2026-09-24T09:17:10Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	29.24 kB	-	-
@sentry/browser - with treeshaking flags	27.5 kB	-	-
@sentry/browser - with treeshaking flags tracing without tracing	27.4 kB	-	-
@sentry/browser (incl. Tracing)	51.15 kB	-	-
@sentry/browser (incl. Tracing + Span Streaming)	51.17 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	54.18 kB	-	-
@sentry/browser (incl. Tracing, Replay)	90.76 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	79.86 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	95.46 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	108.41 kB	-	-
@sentry/browser (incl. Feedback)	46.76 kB	-	-
@sentry/browser (incl. sendFeedback)	34.3 kB	-	-
@sentry/browser (incl. FeedbackAsync)	39.41 kB	-	-
@sentry/browser (incl. Metrics)	30.25 kB	-	-
@sentry/browser (incl. Logs)	30.51 kB	-	-
@sentry/browser (incl. Metrics & Logs)	31.18 kB	-	-
@sentry/react	31 kB	-	-
@sentry/react (incl. Tracing)	53.45 kB	-	-
@sentry/vue	36.74 kB	-	-
@sentry/vue (incl. Tracing)	53.7 kB	-	-
@sentry/svelte	29.26 kB	-	-
CDN Bundle	30.93 kB	-	-
CDN Bundle (incl. Tracing)	51.69 kB	-	-
CDN Bundle (incl. Logs, Metrics)	33.2 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics)	53.66 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics)	73.92 kB	-	-
CDN Bundle (incl. Tracing, Replay)	89.28 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	91.25 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	95.45 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	97.42 kB	-	-
CDN Bundle - uncompressed	91.4 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	153.77 kB	-	-
CDN Bundle (incl. Logs, Metrics) - uncompressed	97.97 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	159.73 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	227.54 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	273.5 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	279.44 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	287.2 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	293.13 kB	-	-
@sentry/nextjs (client)	55.77 kB	-	-
@sentry/sveltekit (client)	51.59 kB	-	-
@sentry/core/server	39.95 kB	-	-
@sentry/core/browser	13.63 kB	-	-
@sentry/node	136.67 kB	+1.95%	+2.61 kB 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)	82.56 kB	+0.17%	+137 B 🔺
@sentry/node - without tracing	90.58 kB	+0.17%	+146 B 🔺
@sentry/node - without channel injection	115.12 kB	+2.26%	+2.54 kB 🔺
@sentry/aws-serverless	98.85 kB	+0.14%	+138 B 🔺
@sentry/cloudflare (withSentry) - minified	206.49 kB	-	-
@sentry/cloudflare (withSentry)	513.73 kB	-	-

View base workflow run

chargome · 2026-09-24T09:30:25Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

cursor · 2026-09-24T09:35:40Z

+                  expect(operationSpans).toEqual([]);
+                  querySpans.forEach(span => expect(span.parent_span_id).toBe(segment?.span_id));
+                  return;
+                }


Test branches on instrumentation mode

Low Severity

The new Prisma v8 test branches on expectsOperationSpans and returns early for the CJS-on-older-Node path. That hides two different user-visible outcomes in one case: operation spans nested over pg queries versus pg-only spans parented to the transaction. This was flagged because the review rules call out conditionals in a single test.

^{Triggered by project rule: PR Review Guidelines for Cursor Bot}

^{Reviewed by Cursor Bugbot for commit 685f3c5. Configure here.}

chargome · 2026-09-24T09:39:30Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

chargome · 2026-09-24T10:13:13Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

JPeer264 · 2026-09-25T06:52:22Z

-      (createRunner, test) => {
-        test('should instrument PostgreSQL queries from Prisma ORM via pg', { timeout: 75_000 }, async () => {
+      (createRunner, test, mode) => {
+        if (mode === 'cjs' && !cjsLoadsInstrumentedEsm) {


q: Can't we use a conditionalTest({ min: 22 }) for this instead?

Done: conditionalTest({ min: 22 }) and conditionalTest({ max: 21 }) now pick the two CJS variants; the manual version parsing is gone.

chargome · 2026-09-25T11:57:43Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

chargome · 2026-09-25T12:35:38Z

bugbot run

Prisma 8 has no tracing surface, so wrap its ORM terminals via orchestrion instead. Each ORM call gets a `prisma:client:operation` span (`db.operation.name`, `db.collection.name`, plus v7's `method`, `model` and `name`) with the `pg` query spans nested underneath. No user code is needed. The patch point is `CollectionImpl` in the transitive `@prisma/orm-family-sql` package, pinned to `>=8.0.0-rc.8 <9`. Lazy terminals (`all`, `createAll`, `updateAll`, `deleteAll`) return a single-use thenable that orchestrion's promise wrapper would consume, so they are wrapped `Sync` and the subscriber hooks `toArray` and the async iterator instead. Terminals calling terminals reuse the outer span. Operation spans require a parent span. CommonJS apps load the ESM-only runtime through `require(esm)`, which only the synchronous module hooks (Node 24.13 / 25.1) transform; older Node keeps `pg`-only spans in CJS. ESM apps are fully covered. Fixes #24237 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chargome · 2026-09-25T12:39:28Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 8f706a5. Configure here.}

Prisma 8 is instrumented through diagnostics channels starting with SDK 11.1.0. Add it to the supported versions and note its span shape and limitations. Refs getsentry/sentry-javascript#24682 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

## pnpm-workspace.yaml (default) ## Dependency Updates | Package | From | To | Type | | --- | --- | --- | --- | | `@sentry/cloudflare` | 11.0.0 | 11.1.0 | minor | | `@sentry/react` | 11.0.0 | 11.1.0 | minor | ## Release Notes <details> <summary><b>@sentry/cloudflare</b> (11.0.0 → 11.1.0)</summary> ### Important Changes - **feat(server-utils): Auto-instrument MCP servers via orchestrion ([#24529](getsentry/sentry-javascript#24529 A new default `mcpServerIntegration` wraps every `McpServer` instance (from `@modelcontextprotocol/server` and `@modelcontextprotocol/sdk`) when it is created. You no longer need to call `wrapMcpServerWithSentry` manually. You can still call `wrapMcpServerWithSentry` to override options, for example `recordInputs: false`. - **feat(node): Support Prisma 8 in `prismaIntegration` ([#24682](getsentry/sentry-javascript#24682 `prismaIntegration` now creates a `prisma:client:operation` span for each Prisma 8 ORM call, with the database query spans nested below it. No code changes are necessary. - **feat(server-utils): Add TypeSafe integration ([#24703](getsentry/sentry-javascript#24703 A new default `typesafeIntegration` creates a `gen_ai.evaluate` span for each TypeSafe Jev call through `@typesafe-ai/sdk` (`TypeSafeClient.systemOne`). For runtimes without auto-instrumentation, use `instrumentTypeSafeClient()`. - **feat(server-utils): Instrument Vercel AI `experimental_evaluate` ([#24694](getsentry/sentry-javascript#24694 Vercel AI `experimental_evaluate` calls now create a `gen_ai.evaluate` span, with the state and questions as input messages and the answers as output messages. ### Other Changes - feat(browser): Add `onError` callback to `showReportDialog` ([#24780](getsentry/sentry-javascript#24780)) - feat(bun): Add client address, port and protocol to Bun.serve spans ([#24523](getsentry/sentry-javascript#24523)) - feat(cloudflare): Re-export httpServerIntegration from /request ([#24614](getsentry/sentry-javascript#24614)) - feat(remix): Add Remix 3 export subpaths and optional peer deps ([#24697](https://github.com/getsentry/sentry-javascr …[full notes](https://github.com/getsentry/sentry-javascript/releases/tag/11.1.0) </details> <details> <summary><b>@sentry/react</b> (11.0.0 → 11.1.0)</summary> ### Important Changes - **feat(server-utils): Auto-instrument MCP servers via orchestrion ([#24529](getsentry/sentry-javascript#24529 A new default `mcpServerIntegration` wraps every `McpServer` instance (from `@modelcontextprotocol/server` and `@modelcontextprotocol/sdk`) when it is created. You no longer need to call `wrapMcpServerWithSentry` manually. You can still call `wrapMcpServerWithSentry` to override options, for example `recordInputs: false`. - **feat(node): Support Prisma 8 in `prismaIntegration` ([#24682](getsentry/sentry-javascript#24682 `prismaIntegration` now creates a `prisma:client:operation` span for each Prisma 8 ORM call, with the database query spans nested below it. No code changes are necessary. - **feat(server-utils): Add TypeSafe integration ([#24703](getsentry/sentry-javascript#24703 A new default `typesafeIntegration` creates a `gen_ai.evaluate` span for each TypeSafe Jev call through `@typesafe-ai/sdk` (`TypeSafeClient.systemOne`). For runtimes without auto-instrumentation, use `instrumentTypeSafeClient()`. - **feat(server-utils): Instrument Vercel AI `experimental_evaluate` ([#24694](getsentry/sentry-javascript#24694 Vercel AI `experimental_evaluate` calls now create a `gen_ai.evaluate` span, with the state and questions as input messages and the answers as output messages. ### Other Changes - feat(browser): Add `onError` callback to `showReportDialog` ([#24780](getsentry/sentry-javascript#24780)) - feat(bun): Add client address, port and protocol to Bun.serve spans ([#24523](getsentry/sentry-javascript#24523)) - feat(cloudflare): Re-export httpServerIntegration from /request ([#24614](getsentry/sentry-javascript#24614)) - feat(remix): Add Remix 3 export subpaths and optional peer deps ([#24697](https://github.com/getsentry/sentry-javascr …[full notes](https://github.com/getsentry/sentry-javascript/releases/tag/11.1.0) </details> --- *This PR was auto-generated by [catalog-update-action](https://github.com/brandhaug/catalog-update-action).* Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chargome added this pull request to stack #24684 September 24, 2026 09:07

chargome self-assigned this Sep 24, 2026

cursor Bot reviewed Sep 24, 2026

View reviewed changes

chargome force-pushed the feat/prisma-8-instrumentation branch from 4e7097b to 685f3c5 Compare September 24, 2026 09:30

cursor Bot reviewed Sep 24, 2026

View reviewed changes

chargome force-pushed the feat/prisma-8-instrumentation branch from 685f3c5 to 3e27580 Compare September 24, 2026 09:39

cursor Bot reviewed Sep 24, 2026

View reviewed changes

chargome force-pushed the feat/prisma-8-instrumentation branch from 3e27580 to 268cb2f Compare September 24, 2026 10:13

cursor Bot reviewed Sep 24, 2026

View reviewed changes

chargome marked this pull request as ready for review September 24, 2026 12:03

chargome requested review from a team as code owners September 24, 2026 12:03

chargome requested review from JPeer264, andreiborza and isaacs and removed request for a team September 24, 2026 12:03

JPeer264 approved these changes Sep 25, 2026

View reviewed changes

chargome force-pushed the feat/prisma-8-instrumentation branch from 268cb2f to ed14806 Compare September 25, 2026 11:57

cursor Bot reviewed Sep 25, 2026

View reviewed changes

chargome force-pushed the feat/prisma-8-instrumentation branch from ed14806 to 8f706a5 Compare September 25, 2026 12:38

cursor Bot reviewed Sep 25, 2026

View reviewed changes

chargome merged commit aa12819 into develop Sep 25, 2026
257 of 287 checks passed

chargome deleted the feat/prisma-8-instrumentation branch September 25, 2026 14:01

chargome mentioned this pull request Sep 25, 2026

docs(js): Document Prisma 8 support in prismaIntegration getsentry/sentry-docs#19628

Draft

sentry-release-bot Bot mentioned this pull request Sep 28, 2026

publish: getsentry/sentry-javascript@11.1.0 getsentry/publish#9685

Closed

47 tasks

github-actions Bot mentioned this pull request Sep 28, 2026

Prisma 8 support for prismaIntegration #24237

Closed

brandhaug mentioned this pull request Oct 2, 2026

chore(deps): bump sentry dependencies brandhaug/b2b-saas-starter#542

Merged

Uh oh!

Conversation

chargome commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chargome commented Sep 24, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot Sep 24, 2026

Choose a reason for hiding this comment

Uncommented non-null assertions

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

chargome commented Sep 24, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor Bot Sep 24, 2026

Choose a reason for hiding this comment

Test branches on instrumentation mode

Uh oh!

chargome commented Sep 24, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chargome commented Sep 24, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JPeer264 Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

chargome Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

chargome commented Sep 25, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chargome commented Sep 25, 2026

Uh oh!

chargome commented Sep 25, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chargome commented Sep 24, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading