fix(tanstackstart-react): Reject non-POST requests to the managed tunnel route - #24615
Merged
Merged
Conversation
…nel route The managed tunnel route only defined a POST handler, so other methods fell through to SSR-rendering the app, running root route loaders. Add an ANY handler that returns 405. Fixes #24605 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
3 tasks
Lms24
marked this pull request as ready for review
September 23, 2026 07:29
Lms24
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
September 23, 2026 07:29
andreiborza
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a tunnel route bug where a non-POST (or rather GET) request to the route would cause TSS to render a page rather than reject the request on that route. This adds an
ANYhandler that returns405withAllow: POST.POSTstill takes precedence, so real tunnel requests are unchanged.Fixes #24605