feat(tanstackstart-react): Emit low-cardinality names for function spans - #24568
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 155db83. Configure here.
Contributor
size-limit report 📦
|
Lms24
marked this pull request as ready for review
September 22, 2026 12:27
Lms24
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
September 22, 2026 12:27
chargome
approved these changes
Sep 23, 2026
Lms24
force-pushed
the
fix/tanstackstart-function-span-names
branch
2 times, most recently
from
September 23, 2026 07:00
c776409 to
275b85b
Compare
The server function span was named after the request path, which carries
the server function's generated id, so every server function produced an
unbounded set of span names under span streaming.
Name the span after the function it wraps: `serverFn` at start, and the
server function's own name once the global function middleware resolves
it. That middleware derived the request method by splitting the span
name, which no longer holds a method, so it now reads `http.request.method`
off the span instead. Since the `function` op's description template is
`{{code.function.name}}` and nothing else, Relay cannot infer the request
path - the previous name is kept on `sentry.description`.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…cycles The span starts with a `serverFn` placeholder because the function's name is not known until the global function middleware runs. That middleware only replaced the placeholder under span streaming, so static-lifecycle spans kept `serverFn` even though the real name was available. Resolve the attribute in both lifecycles and gate only `sentry.description`, which exists solely to carry the request path past Relay's streaming description template. This matches the ember and sveltekit `function` spans, which both set `code.function.name` unconditionally. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…span attributes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
fix/tanstackstart-function-span-names
branch
from
September 23, 2026 07:17
275b85b to
7e07d34
Compare
Lms24
changed the title
function spansfunction spans
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server function span was named after the request path, which carries TanStack's generated server-function id, so every server function produced an unbounded set of span names under span streaming. It is now named after the function it wraps:
serverFnat start, and the server function's own name once the global function middleware resolves it.Two knock-on changes worth a look: that middleware used to recover the request method by splitting the span name, which no longer contains one, so it reads
http.request.methodoff the span instead (newly set at the start site). And since thefunctionop's description template is{{code.function.name}}alone, Relay cannot infer the request path back — the previous name is kept onsentry.description, streaming branch only.🤖 Generated with Claude Code