Conversation
…PC calls Backport of: #24447
JPeer264
marked this pull request as ready for review
September 18, 2026 17:33
JPeer264
requested review from
andreiborza,
isaacs and
mydea
and removed request for
a team and
mydea
September 18, 2026 17:33
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #24447
Differences to the original PR
packages/cloudflare/src/wrapMethodWithSentry.ts: added thespanNameresolver (string | (rpcMeta) => string | undefined) from feat(cloudflare)!: Replace enableRpcTracePropagation with rpcTracePropagationBindings #23486. The fix depends on it to skip the span for untraced calls, and v10 only accepts a string.packages/cloudflare/src/durableobject.ts: kept the v10alwaysTracepath for the deprecatedinstrumentPrototypeMethodsoption unchanged (every call, internal ones included, gets anrpcspan). The new capture-only path applies only withenableRpcTracePropagation. Uses'rpc'instead ofRPCfrom@sentry/conventions, which v10 does not depend on. The JSDoc keeps the v10 note that RPC methods are instrumented only withenableRpcTracePropagation.packages/cloudflare/test/durableobject.test.ts,suites/durableobject/rpc-without-trace/index.ts: setenableRpcTracePropagation: true, because v10 does not instrument RPC methods by default.suites/tracing/propagation/worker-do-rpc-overlapping/vite.config.mts: set_experimental: { autoInstrumentation: true }, because Vite auto-instrumentation is opt-in on v10.On v10 the fix therefore covers Durable Objects with
enableRpcTracePropagation: true(the setup from #24443). Without that option, v10 does not instrument RPC methods at all, same as before.