Conversation
shellmayr
requested review from
a team,
logaretm and
stephanie-anderson
and removed request for
a team
September 18, 2026 07:42
chargome
approved these changes
Sep 18, 2026
…s-sample-rate-to-0.3
s1gr1d
enabled auto-merge (squash)
September 18, 2026 08:31
Contributor
size-limit report 📦
|
… tests With tracesSampleRate at 0.3 the telemetry transaction is only emitted in 30% of runs, so the snapshot tests failed at random. Force sampleRand to 0 when the integration test output directory is set, so the transaction is always sampled. Update the snapshots to the new sample rate. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…to-0.3' of github.com:getsentry/sentry-javascript into shellmayr/chore/move-bundler-plugin-traces-sample-rate-to-0.3 # Conflicts: # dev-packages/bundler-plugin-integration-tests/fixtures/esbuild/telemetry.test.ts # dev-packages/bundler-plugin-integration-tests/fixtures/rolldown/telemetry.test.ts # dev-packages/bundler-plugin-integration-tests/fixtures/rollup3/telemetry.test.ts # dev-packages/bundler-plugin-integration-tests/fixtures/rollup4/telemetry.test.ts # dev-packages/bundler-plugin-integration-tests/fixtures/vite4/telemetry.test.ts # dev-packages/bundler-plugin-integration-tests/fixtures/vite7/telemetry.test.ts # dev-packages/bundler-plugin-integration-tests/fixtures/vite8/telemetry.test.ts # dev-packages/bundler-plugin-integration-tests/fixtures/webpack5/telemetry.test.ts
Regenerate the inline snapshots after merging develop, which changed the transaction envelope shape. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
s1gr1d
deleted the
shellmayr/chore/move-bundler-plugin-traces-sample-rate-to-0.3
branch
September 18, 2026 12:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.