test(node): Assert express http header attributes as arrays - #24416
Merged
Merged
Conversation
#24231 changed `http.request.header.*` span attributes from strings to arrays and updated the affected suites, but missed `suites/express/tracing/test.ts`. Its `content-type`/`user-agent` assertions still expect `type: 'string'`, so the suite fails against a fresh build (arrays) while passing against a stale local build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
marked this pull request as ready for review
September 16, 2026 07:27
mydea
requested review from
andreiborza and
isaacs
and removed request for
a team
September 16, 2026 07:27
mydea
enabled auto-merge (squash)
September 16, 2026 07:27
chargome
approved these changes
Sep 16, 2026
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #24231, which switched
http.request.header.*span attributes from strings to arrays and updated the affected test suites — but misseddev-packages/node-integration-tests/suites/express/tracing/test.ts. Itscontent-typeanduser-agentassertions still expect{ type: 'string' }, so the express tracing suite fails against a freshly built@sentry/core(which now emits arrays) and only passes against a stale local build. This aligns the five affected blocks with the array shape #24231 established ({ type: 'array', value: [...] }).🤖 Generated with Claude Code