fix(v10/browser): Release the XHR virtualError once the request completed - #24307
Merged
Conversation
…pleted Backport of: #24277
Contributor
size-limit report 📦
|
logaretm
marked this pull request as ready for review
September 10, 2026 15:24
logaretm
requested review from
msonnb and
mydea
and removed request for
a team
September 10, 2026 15:24
Lms24
approved these changes
Sep 10, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 50233f0. Configure here.
|
|
||
| expect(inFlightRequest).toBeDefined(); | ||
| expect(firstRequest?.deref()).toBeUndefined(); | ||
| }); |
There was a problem hiding this comment.
Retention test misses proxy leak path
Medium Severity
The new regression test only drives the addEventListener branch, where removeEventListener already drops the handler that closed over virtualError. The leak this fix targets is the onreadystatechange proxy keeping that closure—and the prior request—alive. This test can pass without virtualError = undefined and may not lock in the fix. Flagged because the Testing Conventions in the review rules require a fix PR's test to fail without the change and pass with it.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 50233f0. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #24277