Skip to content

fix(core): Set http header span attributes as string arrays #24231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lms24 wants to merge 2 commits into from
Open

fix(core): Set http header span attributes as string arrays #24231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fab79f2
fix(core): Set http header span attributes as string arrays
Lms24 Sep 9, 2026
a71135a
adjust migration guide
Lms24 Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MIGRATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,8 @@ On server-side HTTP spans, the `content-length` header is now always reported as

The `http.request.header.<key>`/`http.response.header.<key>` attributes now write the header name lowercased as previously but no longer replaces dashes (`-`) with underscores (`_`). For example, the SDK now sets `http.request.header.user-agent` rather than `http.request.header.user_agent`. The same applies to the cookie names in `http.request.header.cookie.<name>` and `http.request.header.set-cookie.<name>`.

Furthermore, the values of `http.request.header.<key>`/`http.response.header.<key>` are now string arrays instead of single strings, as mandated by the semantic conventions. Headers that were sent multiple times previously had their values joined into one string with a semicolon (`;`); they now have one array entry per value. For example, the SDK now sets `http.request.header.accept-encoding` to `['gzip', 'deflate']` rather than `'gzip;deflate'`, and `http.request.header.user-agent` to `['Mozilla/5.0 ...']` rather than `'Mozilla/5.0 ...'`. The cookie attributes (`http.request.header.cookie.<name>`/`http.request.header.set-cookie.<name>`) continue to hold a single string, since a cookie only ever has one value.

#### Network attributes

Network-related span attributes now use the current Sentry semantic conventions, aligned across SDKs. If you query, transform, or alert on the legacy `net.*` fields, update those references:
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/browser-integration-tests/suites/integrations/httpContext-streamed/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ sentryTest('httpContextIntegration captures url, user-agent, and referer', async
value: expect.any(String),
});
expect(pageloadSpan!.attributes['http.request.header.referer']).toEqual({
type: 'string',
value: 'https://sentry.io/',
type: 'array',
value: ['https://sentry.io/'],
});
});

Expand Down
28 changes: 14 additions & 14 deletions dev-packages/cloudflare-integration-tests/suites/public-api/startSpan-streamed/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,36 +226,36 @@ it('sends a streamed span envelope with correct spans for a manually started spa
value: 'node',
},
'http.request.header.accept': {
type: 'string',
value: '*/*',
type: 'array',
value: ['*/*'],
},
'http.request.header.accept-encoding': {
type: 'string',
value: 'br, gzip',
type: 'array',
value: ['br, gzip'],
},
'http.request.header.accept-language': {
type: 'string',
value: '*',
type: 'array',
value: ['*'],
},
'http.request.header.cf-connecting-ip': {
type: 'string',
value: '127.0.0.1',
type: 'array',
value: ['127.0.0.1'],
},
'user.ip_address': {
type: 'string',
value: '127.0.0.1',
},
'http.request.header.host': {
type: 'string',
value: expect.stringMatching(/^localhost:.+$/),
type: 'array',
value: [expect.stringMatching(/^localhost:.+$/)],
},
'http.request.header.sec-fetch-mode': {
type: 'string',
value: 'cors',
type: 'array',
value: ['cors'],
},
'http.request.header.user-agent': {
type: 'string',
value: 'node',
type: 'array',
value: ['node'],
},
'http.request.method': {
type: 'string',
Expand Down
50 changes: 25 additions & 25 deletions dev-packages/e2e-tests/test-applications/astro-4/tests/tracing.dynamic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ test.describe('tracing in dynamically rendered (ssr) routes', () => {
'sentry.sdk.name': { value: 'sentry.javascript.astro', type: 'string' },
'url.full': { value: expect.stringContaining('/test-ssr'), type: 'string' },
// demonstrates that the request data integration can extract headers
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate, br, zstd', type: 'string' },
'http.request.header.accept-language': { value: 'en-US', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'navigate', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate, br, zstd'], type: 'array' },
'http.request.header.accept-language': { value: ['en-US'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['navigate'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});
});
});
Expand Down Expand Up @@ -152,11 +152,11 @@ test.describe('nested SSR routes (client, server, server request)', () => {
'sentry.origin': { value: 'auto.http.astro', type: 'string' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'url.full': { value: expect.stringContaining('/user-page/myUsername123'), type: 'string' },
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate, br, zstd', type: 'string' },
'http.request.header.accept-language': { value: 'en-US', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'navigate', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate, br, zstd'], type: 'array' },
'http.request.header.accept-language': { value: ['en-US'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['navigate'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});

// HTTP client span - with span streaming only the domain is kept in the name, the URL lives in
Expand All @@ -174,11 +174,11 @@ test.describe('nested SSR routes (client, server, server request)', () => {
'sentry.op': { value: 'http.server', type: 'string' },
'sentry.origin': { value: 'auto.http.astro', type: 'string' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate', type: 'string' },
'http.request.header.accept-language': { value: '*', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'cors', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate'], type: 'array' },
'http.request.header.accept-language': { value: ['*'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['cors'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});
});

Expand Down Expand Up @@ -215,11 +215,11 @@ test.describe('nested SSR routes (client, server, server request)', () => {
'sentry.origin': { value: 'auto.http.astro', type: 'string' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'url.full': { value: expect.stringContaining('/catchAll/hell0/whatever-do'), type: 'string' },
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate, br, zstd', type: 'string' },
'http.request.header.accept-language': { value: 'en-US', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'navigate', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate, br, zstd'], type: 'array' },
'http.request.header.accept-language': { value: ['en-US'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['navigate'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});
});
});
Expand Down Expand Up @@ -253,11 +253,11 @@ test.describe('parametrized vs static paths', () => {
'sentry.origin': { value: 'auto.http.astro', type: 'string' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'url.full': { value: expect.stringContaining('/user-page/settings'), type: 'string' },
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate, br, zstd', type: 'string' },
'http.request.header.accept-language': { value: 'en-US', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'navigate', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate, br, zstd'], type: 'array' },
'http.request.header.accept-language': { value: ['en-US'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['navigate'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});
});
});
50 changes: 25 additions & 25 deletions dev-packages/e2e-tests/test-applications/astro-5/tests/tracing.dynamic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ test.describe('tracing in dynamically rendered (ssr) routes', () => {
'sentry.sdk.name': { value: 'sentry.javascript.astro', type: 'string' },
'url.full': { value: expect.stringContaining('/test-ssr'), type: 'string' },
// demonstrates that the request data integration can extract headers
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate, br, zstd', type: 'string' },
'http.request.header.accept-language': { value: 'en-US', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'navigate', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate, br, zstd'], type: 'array' },
'http.request.header.accept-language': { value: ['en-US'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['navigate'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});
});
});
Expand Down Expand Up @@ -152,11 +152,11 @@ test.describe('nested SSR routes (client, server, server request)', () => {
'sentry.origin': { value: 'auto.http.astro', type: 'string' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'url.full': { value: expect.stringContaining('/user-page/myUsername123'), type: 'string' },
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate, br, zstd', type: 'string' },
'http.request.header.accept-language': { value: 'en-US', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'navigate', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate, br, zstd'], type: 'array' },
'http.request.header.accept-language': { value: ['en-US'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['navigate'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});

// HTTP client span - with span streaming only the domain is kept in the name, the URL lives in
Expand All @@ -174,11 +174,11 @@ test.describe('nested SSR routes (client, server, server request)', () => {
'sentry.op': { value: 'http.server', type: 'string' },
'sentry.origin': { value: 'auto.http.astro', type: 'string' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate', type: 'string' },
'http.request.header.accept-language': { value: '*', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'cors', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate'], type: 'array' },
'http.request.header.accept-language': { value: ['*'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['cors'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});
});

Expand Down Expand Up @@ -215,11 +215,11 @@ test.describe('nested SSR routes (client, server, server request)', () => {
'sentry.origin': { value: 'auto.http.astro', type: 'string' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'url.full': { value: expect.stringContaining('/catchAll/hell0/whatever-do'), type: 'string' },
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate, br, zstd', type: 'string' },
'http.request.header.accept-language': { value: 'en-US', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'navigate', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate, br, zstd'], type: 'array' },
'http.request.header.accept-language': { value: ['en-US'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['navigate'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});
});
});
Expand Down Expand Up @@ -253,11 +253,11 @@ test.describe('parametrized vs static paths', () => {
'sentry.origin': { value: 'auto.http.astro', type: 'string' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'url.full': { value: expect.stringContaining('/user-page/settings'), type: 'string' },
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate, br, zstd', type: 'string' },
'http.request.header.accept-language': { value: 'en-US', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'navigate', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate, br, zstd'], type: 'array' },
'http.request.header.accept-language': { value: ['en-US'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['navigate'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});
});

Expand Down
10 changes: 5 additions & 5 deletions dev-packages/e2e-tests/test-applications/astro-5/tests/tracing.serverIslands.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ test.describe('tracing in static routes with server islands', () => {
'sentry.op': { value: 'http.server', type: 'string' },
'sentry.origin': { value: 'auto.http.astro', type: 'string' },
'sentry.segment.name.source': { value: 'route', type: 'string' },
'http.request.header.accept': { value: expect.any(String), type: 'string' },
'http.request.header.accept-encoding': { value: 'gzip, deflate, br, zstd', type: 'string' },
'http.request.header.accept-language': { value: 'en-US', type: 'string' },
'http.request.header.sec-fetch-mode': { value: 'cors', type: 'string' },
'http.request.header.user-agent': { value: expect.any(String), type: 'string' },
'http.request.header.accept': { value: [expect.any(String)], type: 'array' },
'http.request.header.accept-encoding': { value: ['gzip, deflate, br, zstd'], type: 'array' },
'http.request.header.accept-language': { value: ['en-US'], type: 'array' },
'http.request.header.sec-fetch-mode': { value: ['cors'], type: 'array' },
'http.request.header.user-agent': { value: [expect.any(String)], type: 'array' },
});

// unfortunately, the server island trace id is not the same as the client pageload trace id
Expand Down
Loading
Loading