Conversation
s1gr1d
requested review from
mydea and
nicohrubec
and removed request for
a team
September 7, 2026 12:45
Member
Author
|
bugbot run |
Contributor
size-limit report 📦
|
7 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7b3c0ee. Configure here.
Contributor
|
👋 @mydea, @nicohrubec — Please review this PR when you get a chance! |
chargome
reviewed
Sep 14, 2026
chargome
left a comment
chargome
left a comment
Member
There was a problem hiding this comment.
Added a question, needs a rebase still
| * @internal Exported for the Sentry Nuxt SDK, not part of the stable public API. | ||
| * @experimental May change or be removed in any release. | ||
| */ | ||
| export function INTERNAL_extendVueRootRenderSpan(app: Vue): void { |
Member
There was a problem hiding this comment.
We only use this in the nuxt package AFAICT, could we just define it there and not add it to public exports?
Member
Author
There was a problem hiding this comment.
it's defined in the vue package, because it needs the instrumentedApps. But I think I'll just remove this function because this is only relevant to close the "async gap": when a root span ends before <Suspense> resolves the page.
So far, we did not do this and we rather ship this as an extra feature.
Contributor
|
👋 @mydea, @nicohrubec — Please review this PR when you get a chance! |
2 tasks
# Conflicts: # dev-packages/e2e-tests/test-applications/vue-3/tests/performance.test.ts
Contributor
|
👋 @mydea, @nicohrubec — Please review this PR when you get a chance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nuxt 5 disables Vue's Options API by default (nuxt/nuxt#35791). That turns
app.mixin()into a silent no-op, and every Vue UI span comes from that mixin:Application RenderandVue <Root>disappear with no signal.When the mixin is dropped, the SDK now wraps
app.mount()and calls the same mixin hook bodies, so the default spans stay identical. The Nuxt SDK additionally extends the root span until<Suspense>resolves.trackComponentsstill needs the Options API and warns when it is lost. Vue 2 behavior stays unchanged (always needs Options API as it's not possible otherwise).Closes #23375
Docs follow-up: getsentry/sentry-docs#19290