Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const app = new Hono();

app.use(
sentry(app, {
traceLifecycle: 'static',
dsn: process.env.E2E_TEST_DSN,
environment: 'qa',
tracesSampleRate: 1.0,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const app = new Hono<{ Bindings: { E2E_TEST_DSN: string } }>();

app.use(
sentry(app, env => ({
traceLifecycle: 'static',
dsn: env.E2E_TEST_DSN,
environment: 'qa',
tracesSampleRate: 1.0,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const app = new Hono();

app.use(
sentry(app, {
traceLifecycle: 'static',
dsn: Deno.env.get('E2E_TEST_DSN'),
environment: 'qa',
dataCollection: {},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as Sentry from '@sentry/hono/node';

Sentry.init({
traceLifecycle: 'static',
dsn: process.env.E2E_TEST_DSN,
environment: 'qa',
tracesSampleRate: 1.0,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,80 +1,91 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { waitForStreamedSpan, getSpanOp, collectStreamedSpansUntilSegment } from '@sentry-internal/test-utils';
import { APP_NAME } from './constants';

test.describe('basePath with sub-app routes', () => {
test('traces GET on a sub-app mounted via .basePath().route()', async ({ baseURL }) => {
const transactionPromise = waitForTransaction(APP_NAME, event => {
return event.contexts?.trace?.op === 'http.server' && event.transaction === 'GET /test-basepath/v1/users';
});
const segmentPromise = waitForStreamedSpan(
APP_NAME,
segment =>
segment.is_segment && getSpanOp(segment) === 'http.server' && segment.name === 'GET /test-basepath/v1/users',
);

const response = await fetch(`${baseURL}/test-basepath/v1/users`);
expect(response.status).toBe(200);

const body = await response.json();
expect(body).toEqual({ users: [{ id: 1, name: 'Alice' }] });

const transaction = await transactionPromise;
expect(transaction.transaction).toBe('GET /test-basepath/v1/users');
expect(transaction.contexts?.trace?.op).toBe('http.server');
const segment = await segmentPromise;
expect(segment.name).toBe('GET /test-basepath/v1/users');
expect(getSpanOp(segment)).toBe('http.server');
});

test('traces parameterized route under .basePath().route()', async ({ baseURL }) => {
const transactionPromise = waitForTransaction(APP_NAME, event => {
return event.contexts?.trace?.op === 'http.server' && event.transaction === 'GET /test-basepath/v1/users/:userId';
});
const segmentPromise = waitForStreamedSpan(
APP_NAME,
segment =>
segment.is_segment &&
getSpanOp(segment) === 'http.server' &&
segment.name === 'GET /test-basepath/v1/users/:userId',
);

const response = await fetch(`${baseURL}/test-basepath/v1/users/42`);
expect(response.status).toBe(200);

const body = await response.json();
expect(body).toEqual({ userId: '42' });

const transaction = await transactionPromise;
expect(transaction.transaction).toBe('GET /test-basepath/v1/users/:userId');
expect(transaction.contexts?.trace?.op).toBe('http.server');
const segment = await segmentPromise;
expect(segment.name).toBe('GET /test-basepath/v1/users/:userId');
expect(getSpanOp(segment)).toBe('http.server');
});
});

// TODO: this test is currently skipped because we do not yet support middleware registered on new instances (e.g. here via .basePath(..).use(...)).
test.skip('.basePath() middleware instrumentation', () => {
test('creates middleware span for .use() on .basePath() clone', async ({ baseURL }) => {
const transactionPromise = waitForTransaction(APP_NAME, event => {
return event.contexts?.trace?.op === 'http.server' && event.transaction === 'GET /test-basepath-mw/hello';
});
const segmentPromise = collectStreamedSpansUntilSegment(
APP_NAME,
segment => getSpanOp(segment) === 'http.server' && segment.name === 'GET /test-basepath-mw/hello',
);

const response = await fetch(`${baseURL}/test-basepath-mw/hello`);
expect(response.status).toBe(200);

const body = await response.json();
expect(body).toEqual({ greeting: 'world' });

const transaction = await transactionPromise;
expect(transaction.transaction).toBe('GET /test-basepath-mw/hello');
const segmentSpans = await segmentPromise;
const segment = segmentSpans.find(
segment =>
segment.is_segment && getSpanOp(segment) === 'http.server' && segment.name === 'GET /test-basepath-mw/hello',
)!;
expect(segment.name).toBe('GET /test-basepath-mw/hello');

const spans = transaction.spans || [];
const middlewareSpan = spans.find(
(span: { description?: string; op?: string }) =>
span.op === 'middleware' && span.description === 'basepathMiddleware',
const spans = segmentSpans.filter(
span => !span.is_segment && span.attributes['sentry.segment.id']?.value === segment.span_id,
);
const middlewareSpan = spans.find(span => getSpanOp(span) === 'middleware' && span.name === 'basepathMiddleware');

expect(middlewareSpan).toBeDefined();
expect(middlewareSpan?.origin).toBe('auto.middleware.hono');
expect(middlewareSpan?.attributes['sentry.origin']?.value).toBe('auto.middleware.hono');
});
});

test('traces .get() route registered after .basePath()/.route() chains', async ({ baseURL }) => {
const transactionPromise = waitForTransaction(APP_NAME, event => {
return event.contexts?.trace?.op === 'http.server' && event.transaction === 'GET /test-late-get';
});
const segmentPromise = waitForStreamedSpan(
APP_NAME,
segment => segment.is_segment && getSpanOp(segment) === 'http.server' && segment.name === 'GET /test-late-get',
);

const response = await fetch(`${baseURL}/test-late-get`);
expect(response.status).toBe(200);

const body = await response.json();
expect(body).toEqual({ registered: 'after-chains' });

const transaction = await transactionPromise;
expect(transaction.transaction).toBe('GET /test-late-get');
expect(transaction.contexts?.trace?.op).toBe('http.server');
const segment = await segmentPromise;
expect(segment.name).toBe('GET /test-late-get');
expect(getSpanOp(segment)).toBe('http.server');
});
Loading
Loading