Skip to content

test(e2e): Use the existing streamed-span helpers in the nestjs-11 specs #24127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 1 commit into from
Sep 7, 2026
Merged

test(e2e): Use the existing streamed-span helpers in the nestjs-11 specs #24127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 13 additions & 19 deletions dev-packages/e2e-tests/test-applications/nestjs-11/tests/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,8 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';
import { collectStreamedSpansUntilSegment, waitForError } from '@sentry-internal/test-utils';

const APP_NAME = 'nestjs-11';

/**
* Resolves once the request's segment span has been streamed, which is how these specs know the
* request finished and any error it would have produced had its chance to be sent.
*/
function waitForSegmentSpan(name: string): Promise<unknown> {
return waitForStreamedSpan(APP_NAME, span => span.is_segment && span.name === name);
}

test('Sends exception to Sentry', async ({ baseURL }) => {
const errorEventPromise = waitForError(APP_NAME, event => {
return !event.type && event.exception?.values?.[0]?.value === 'This is an exception with id 123';
Expand Down Expand Up @@ -63,17 +55,19 @@ test('Does not send HttpExceptions to Sentry', async ({ baseURL }) => {
return event?.transaction === 'GET /test-expected-500-exception/:id';
});

const segmentSpanPromise400 = waitForSegmentSpan('GET /test-expected-400-exception/:id');
const segmentSpanPromise500 = waitForSegmentSpan('GET /test-expected-500-exception/:id');
// Waiting for each request's segment span is how this spec knows the request finished and
// any error it would have produced had its chance to be sent.
const spansPromise400 = collectStreamedSpansUntilSegment(APP_NAME, 'GET /test-expected-400-exception/:id');
const spansPromise500 = collectStreamedSpansUntilSegment(APP_NAME, 'GET /test-expected-500-exception/:id');

const response400 = await fetch(`${baseURL}/test-expected-400-exception/123`);
expect(response400.status).toBe(400);

const response500 = await fetch(`${baseURL}/test-expected-500-exception/123`);
expect(response500.status).toBe(500);

await segmentSpanPromise400;
await segmentSpanPromise500;
await spansPromise400;
await spansPromise500;

(await fetch(`${baseURL}/flush`)).text();

Expand All @@ -91,12 +85,12 @@ test('Does not send RpcExceptions to Sentry', async ({ baseURL }) => {
return event?.transaction === 'GET /test-expected-rpc-exception/:id';
});

const segmentSpanPromise = waitForSegmentSpan('GET /test-expected-rpc-exception/:id');
const spansPromise = collectStreamedSpansUntilSegment(APP_NAME, 'GET /test-expected-rpc-exception/:id');

const response = await fetch(`${baseURL}/test-expected-rpc-exception/123`);
expect(response.status).toBe(500);

await segmentSpanPromise;
await spansPromise;

(await fetch(`${baseURL}/flush`)).text();

Expand All @@ -116,7 +110,7 @@ test('Global exception filter registered in main module is applied and exception
return event?.transaction === 'GET /example-exception-global-filter';
});

const segmentSpanPromise = waitForSegmentSpan('GET /example-exception-global-filter');
const spansPromise = collectStreamedSpansUntilSegment(APP_NAME, 'GET /example-exception-global-filter');

const response = await fetch(`${baseURL}/example-exception-global-filter`);
const responseBody = await response.json();
Expand All @@ -129,7 +123,7 @@ test('Global exception filter registered in main module is applied and exception
message: 'Example exception was handled by global filter!',
});

await segmentSpanPromise;
await spansPromise;

(await fetch(`${baseURL}/flush`)).text();

Expand All @@ -149,7 +143,7 @@ test('Local exception filter registered in main module is applied and exception
return event?.transaction === 'GET /example-exception-local-filter';
});

const segmentSpanPromise = waitForSegmentSpan('GET /example-exception-local-filter');
const spansPromise = collectStreamedSpansUntilSegment(APP_NAME, 'GET /example-exception-local-filter');

const response = await fetch(`${baseURL}/example-exception-local-filter`);
const responseBody = await response.json();
Expand All @@ -162,7 +156,7 @@ test('Local exception filter registered in main module is applied and exception
message: 'Example exception was handled by local filter!',
});

await segmentSpanPromise;
await spansPromise;

(await fetch(`${baseURL}/flush`)).text();

Expand Down
Loading