feat(vue): Register Vue route provider - #23793
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 24, 2026 18:04
a1394dd to
ece4da5
Compare
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 24, 2026 18:14
ece4da5 to
a309ce7
Compare
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 24, 2026 18:30
a309ce7 to
3dbcc53
Compare
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 24, 2026 18:50
3dbcc53 to
227053e
Compare
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
2 times, most recently
from
September 24, 2026 19:59
22d7992 to
e741e61
Compare
logaretm
changed the title
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 24, 2026 21:20
e741e61 to
b344925
Compare
logaretm
marked this pull request as ready for review
September 24, 2026 21:26
logaretm
requested review from
chargome,
nicohrubec and
s1gr1d
and removed request for
a team
September 24, 2026 21:26
s1gr1d
reviewed
Sep 25, 2026
| defaultIntegrations: [...getDefaultIntegrations(options), vueIntegration()], | ||
| // The router is read off the app on each call, so `app.use(router)` can run either side of `init`, and | ||
| // users who never pass `router` to the tracing integration still get parameterized routes. | ||
| ...(options.app && { routeProvider: createVueRouteProvider(() => getRouterFromApp(options.app)) }), |
Member
There was a problem hiding this comment.
In Vue 2, this would be options.App (make sure to also test Vue 2 E2E)
Member
Author
There was a problem hiding this comment.
do we have a Vue 2 E2E? should I add one?
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 28, 2026 22:08
b344925 to
fa6bf94
Compare
Contributor
|
👋 @chargome, @nicohrubec — Please review this PR when you get a chance! |
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 29, 2026 19:34
fa6bf94 to
57914a9
Compare
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 30, 2026 16:49
57914a9 to
63d9a6f
Compare
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 30, 2026 16:52
63d9a6f to
8a6336a
Compare
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 30, 2026 17:00
8a6336a to
3f219dc
Compare
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
September 30, 2026 17:02
3f219dc to
0b03209
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 89d893e. Configure here.
| // The router is looked up lazily because it may be installed after `init`. A user's `routeProvider` wins. | ||
| if (!getRouteProvider(client)) { | ||
| const { app, Vue } = options; | ||
| const getRouter = app ? () => getRouterFromApp(app) : captureRouterFromVue(Vue!); |
There was a problem hiding this comment.
Non-null assertion lacks required comment
Low Severity
A new non-null assertion on Vue has no comment explaining why a safer type is not possible. The earlier app/Vue guard makes the assertion valid, but the project rule still requires that comment on new ! uses in SDK source. Flagged because this was mentioned in the review rules file.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 89d893e. Configure here.
`vue-router` sets `app.config.globalProperties.$router` when it installs, and the SDK is already given the app, so the provider needs no new option and no router passed to the tracing integration. Registered from `init()`, so route parameterization no longer depends on tracing being enabled and works for users who never pass `router` to `browserTracingIntegration`. The router is looked up per call rather than captured, because `app.use(router)` may run either side of `Sentry.init()`. Returns the matched path rather than `route.name` even under `routeLabel: 'name'`: callers set `url.template` from this and a route name is an identifier, not a template. The navigation instrumentation still names the span after the route name when the user asked for it.
logaretm
force-pushed
the
awad/route-provider-vue-app
branch
from
October 1, 2026 07:59
89d893e to
3b4b45e
Compare
s1gr1d
approved these changes
Oct 1, 2026
s1gr1d
left a comment
s1gr1d
left a comment
Member
There was a problem hiding this comment.
Looks good but I think you need to update the PR description now.
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider for Vue so route parameterization works without tracing and without passing
routertobrowserTracingIntegration.The provider is registered in
vueIntegration'ssetup, so it picks upappwhether it's passed toinitor to the integration; arouteProviderpassed toinittakes precedence. On Vue 3 the router is read offapp.config.globalProperties.$routeron each call, sinceapp.use(router)may run either side ofSentry.init(). Vue 2 only exposes the router on instances, so abeforeCreatemixin picks it up from the rootnew Vue({ router }). Until that instance exists nothing resolves, so the Vue 2 pageload span keeps the raw URL.resolve()matches the router's own location, not the browser's, so URLs are converted first: the path comes from the hash in hash mode, and the router'sbaseis stripped otherwise (Vue Router 3 and 4).Returns the matched path rather than
route.name, even underrouteLabel: 'name'. Callers seturl.templatefrom this, and a route name is an identifier, not a template.The factory is exported as
_INTERNAL_createVueRouteProviderfor Nuxt; it isn't meant for users.Part of #23556