ref: Use op constants from conventions - #23742
Merged
Merged
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 34889f6. Configure here.
Contributor
size-limit report 📦
|
msonnb
marked this pull request as ready for review
August 31, 2026 07:37
msonnb
requested review from
andreiborza,
isaacs,
logaretm,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team and
nicohrubec
August 31, 2026 07:37
The production code now sets ops via the SENTRY_OP attribute instead of the `op` span option, so spy-based assertions on startSpan arguments must expect the attribute. Also point the langchain integration test at the conventions constant since the local alias was removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
msonnb
force-pushed
the
ms/span-op-constants
branch
from
August 31, 2026 09:12
859d645 to
6b09e08
Compare
s1gr1d
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces string literals with exported constants from conventions that have been released in the meantime.