feat: Emit low-cardinality http.server span names in framework SDKs - #23597
Merged
chargome merged 1 commit intoAug 26, 2026
Conversation
Contributor
size-limit report 📦
|
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-frameworks
branch
from
August 26, 2026 07:20
80e4f09 to
ef8061b
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-frameworks
branch
2 times, most recently
from
August 26, 2026 08:06
865560a to
9b5e334
Compare
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-frameworks
branch
from
August 26, 2026 08:11
9b5e334 to
330935b
Compare
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-frameworks
branch
2 times, most recently
from
August 26, 2026 09:28
2d61e3b to
b37ecb0
Compare
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-frameworks
branch
from
August 26, 2026 10:10
b37ecb0 to
30260d0
Compare
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-frameworks
branch
from
August 26, 2026 12:22
30260d0 to
051df94
Compare
Member
Author
|
bugbot run 📿 |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 051df94. Configure here.
chargome
requested review from
a team,
Lms24,
andreiborza,
isaacs,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
August 26, 2026 13:51
Lms24
approved these changes
Aug 26, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
I think this shows that we'll loose quite a few span names to just the method but unfortunately, that's the consequence of the low card. requirement. So this is fine for now. If we find specific areas where we could do a better job at span names we can revisit later and improve them step by step.
Applies the same span-streaming gate to the runtime and framework SDKs so no integration keeps a raw URL in an http.server span name. Requests that resolve to a route are unchanged. Three sites differ from the rest and are worth a closer look: remix reads its own span name back, sveltekit also renames SvelteKit's native root span, and nextjs renames in a `spanStart` hook because Next.js — not the SDK — creates that span. Refs #23527 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-frameworks
branch
from
August 26, 2026 15:00
051df94 to
9b9852f
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
chargome
added a commit
that referenced
this pull request
Aug 26, 2026
) Adds the `http.server` row to the v11 span name section and calls out that `tracesSampler` and `ignoreSpans` can no longer match on span name — they run at span start, before a route exists, so name-based rules stop matching silently. Stacked on #23597. Fixes #23527 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the same span-streaming gate across the runtime and framework SDKs so no integration keeps a raw URL in an
http.serverspan name; routed requests are unchanged. Stacked on #23596.Worth a closer look: remix reads its own span name back, sveltekit also renames SvelteKit's native root span, and nextjs renames in a
spanStarthook because Next.js creates that span. Refs #23527