refactor(core): Consolidate PersistingScopeObserver error handling#5692
Open
runningcode wants to merge 1 commit into
Open
refactor(core): Consolidate PersistingScopeObserver error handling#5692runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
runningcode
force-pushed
the
no/java-608-serialize-runnable-churn
branch
from
5946bb5 to
31e6c7f
Compare
📲 Install BuildsAndroid
|
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
Extract the duplicated try/catch in PersistingScopeObserver.serializeToDisk into a single runSafely helper used by both the on-executor and submit paths. Pure internal cleanup; error-handling behavior is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
runningcode
force-pushed
the
no/java-608-serialize-runnable-churn
branch
from
31e6c7f to
d4b2036
Compare
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcc92 | 309.54 ms | 380.32 ms | 70.78 ms |
| 4e3e79d | 328.10 ms | 395.64 ms | 67.54 ms |
| 8c1fb22 | 316.62 ms | 352.78 ms | 36.16 ms |
| b67bb28 | 307.59 ms | 341.24 ms | 33.65 ms |
| d15471f | 361.89 ms | 378.07 ms | 16.18 ms |
| 22f4345 | 313.52 ms | 364.96 ms | 51.44 ms |
| 6727e14 | 337.22 ms | 373.94 ms | 36.71 ms |
| fc5ccaf | 322.49 ms | 405.25 ms | 82.76 ms |
| 22f4345 | 314.79 ms | 375.02 ms | 60.23 ms |
| 2195398 | 319.02 ms | 342.38 ms | 23.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| 4e3e79d | 0 B | 0 B | 0 B |
| 8c1fb22 | 0 B | 0 B | 0 B |
| b67bb28 | 0 B | 0 B | 0 B |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| 6727e14 | 1.58 MiB | 2.28 MiB | 718.64 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| 2195398 | 0 B | 0 B | 0 B |
romtsn
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JAVA-608.
Description
PersistingScopeObserver.serializeToDiskduplicated the same try/catch error-handling block in both the on-executor path and thesubmitwrapper. This extracts it into a singlerunSafely(task)helper used by both.#skip-changelog