test: Add e2e test for v11 orchestrion instrumentation - #1437
Merged
Merged
Conversation
timfish
force-pushed
the
feat/vnext-orchestrion-tests
branch
from
September 24, 2026 10:18
b96d244 to
a8918e8
Compare
timfish
added this pull request to stack #1422
September 24, 2026 10:21
timfish
force-pushed
the
feat/vnext-orchestrion-tests
branch
3 times, most recently
from
September 28, 2026 13:59
8a76adb to
546872d
Compare
timfish
marked this pull request as ready for review
September 28, 2026 14:03
timfish
marked this pull request as draft
September 28, 2026 14:07
timfish
force-pushed
the
feat/vnext-orchestrion-tests
branch
from
September 28, 2026 15:23
546872d to
45283f6
Compare
timfish
marked this pull request as ready for review
September 28, 2026 15:43
nicohrubec
approved these changes
Sep 29, 2026
JPeer264
approved these changes
Sep 29, 2026
| await graphql({ schema, source: '{ hello }', rootValue: { hello: () => 'world' } }); | ||
| }); | ||
|
|
||
| await flush(2000); |
Member
There was a problem hiding this comment.
q: Is this manual flush needed?
Collaborator
Author
There was a problem hiding this comment.
You were right, not needed!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E test that orchestrion diagnostics-channel injection works in the Electron main process.
test-apps/other/orchestrion-graphql/inits the SDK withgraphqlIntegration(), runs an in-processgraphqlquery and asserts the injectedGraphQL queryspan (originauto.graphql.diagnostic_channel). It stays CommonJS (skipEsmAutoTransform) so it canrequire('graphql')after init, once the hook is registered.The Node SDK picks the loader path from the bundled Node version:
Module.register()Module.registerHooks()This also bumps the Sentry SDKs to 11.1.0, which the test needed to pass on Windows. The fix landed in tracing-hooks 0.13.3 (apm-js-collab/tracing-hooks#58) and reached the SDK in 11.1.0 (getsentry/sentry-javascript#24705), so until that release the test failed on Windows with Electron 40+.
11.1.0 also adds
instrumentTypeSafeClient,mcpServerIntegrationandtypesafeIntegration, which are now re-exported from/mainand/utility.