docs(self-hosted): disable sso providers on Troubleshooting Sentry page#17705
Open
docs(self-hosted): disable sso providers on Troubleshooting Sentry page#17705
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+123
to
+126
| ```sql | ||
| DELETE FROM sentry_authidentity WHERE auth_provider_id = 1; | ||
| DELETE FROM sentry_authprovider WHERE id = 1; | ||
| ``` |
Contributor
There was a problem hiding this comment.
Bug: The documented SQL commands to disable SSO are incomplete and will fail if 'default teams' are configured, leaving the database in an inconsistent state.
Severity: HIGH
Suggested Fix
Add a SQL command to delete from the sentry_authprovider_default_teams table before the command that deletes from sentry_authprovider. This manually handles the relationship that the Django ORM would normally cascade, preventing the foreign key violation.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: develop-docs/self-hosted/troubleshooting/sentry.mdx#L123-L126
Potential issue: The troubleshooting documentation provides raw SQL commands to disable
SSO. These commands fail if 'default teams' are configured for the SSO provider.
Specifically, the `DELETE FROM sentry_authprovider` statement fails with a foreign key
constraint violation because it doesn't first delete related entries from the
`sentry_authprovider_default_teams` table. This failure occurs after the `DELETE FROM
sentry_authidentity` command has already succeeded, leaving the database in an
inconsistent state and potentially worsening the user lockout situation.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
From a live troubleshooting session in Discord.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES