Skip to content

feat(ci): replace pre-commit into prek#17703

Open
aldy505 wants to merge 1 commit intomasterfrom
aldy505/ci/migrate-pre-commit-prek
Open

feat(ci): replace pre-commit into prek#17703
aldy505 wants to merge 1 commit intomasterfrom
aldy505/ci/migrate-pre-commit-prek

Conversation

@aldy505
Copy link
Copy Markdown
Collaborator

@aldy505 aldy505 commented May 10, 2026

DESCRIBE YOUR PR

Faster execution than pre-commit. The sentry and self-hosted repo are already using it right now.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link
Copy Markdown

vercel Bot commented May 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment May 10, 2026 2:01pm
sentry-docs Ready Ready Preview, Comment May 10, 2026 2:01pm

Request Review

@aldy505 aldy505 requested review from BYK, jaffrepaul and sfanahata May 10, 2026 13:51
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4a9ff99. Configure here.

Comment thread .pre-commit-config.yaml
description: This hook runs Prettier on JavaScript files
entry: prettier
language: node
files: '\.jsx?$'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-commit hooks skip all TypeScript files

High Severity

The files: '\.jsx?$' pattern only matches .js and .jsx files, but this is a TypeScript/Next.js project where the vast majority of source files are .ts and .tsx (e.g., app/layout.tsx, src/utils.ts, middleware.ts). Both the prettier and eslint hooks will silently skip all TypeScript files, effectively disabling pre-commit linting and formatting for most of the codebase. The pattern needs to include TypeScript extensions, e.g., '\.[jt]sx?$'.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4a9ff99. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant