ref(feedback): Remove deprecated SentryFeedbackWidget#3844
Open
buenaflor wants to merge 1 commit into
Open
Conversation
SentryFeedbackWidget was a deprecated typedef alias for SentryFeedbackForm; the rename is complete, so remove the alias, its export, and the alias-specific test group. BREAKING CHANGE: SentryFeedbackWidget is removed; use SentryFeedbackForm. Fixes GH-3825 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Features
Fixes
DependenciesDeps
Internal Changes
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v10-branch #3844 +/- ##
=============================================
Coverage ? 91.71%
=============================================
Files ? 105
Lines ? 3816
Branches ? 0
=============================================
Hits ? 3500
Misses ? 316
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
buenaflor
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated SentryFeedbackWidget typedef alias (renamed to SentryFeedbackForm previously) from the Flutter package, including its now-obsolete export and alias-only tests, as part of the v10 cleanup.
Changes:
- Deleted
SentryFeedbackWidgetalias file (sentry_feedback_widget.dart). - Removed the deprecated export from
packages/flutter/lib/sentry_flutter.dart. - Removed the alias-specific test group from
sentry_feedback_form_test.dart.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/flutter/test/feedback/sentry_feedback_form_test.dart | Removes tests that only validated the deprecated alias behavior. |
| packages/flutter/lib/src/feedback/sentry_feedback_widget.dart | Deletes the deprecated typedef alias (public API removal). |
| packages/flutter/lib/sentry_flutter.dart | Stops exporting the removed alias symbol from the Flutter barrel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
7
to
10
| export 'src/binding_wrapper.dart' | ||
| show BindingWrapper, SentryWidgetsFlutterBinding; | ||
| export 'src/feedback/sentry_feedback_form.dart'; | ||
| // ignore: deprecated_member_use_from_same_package | ||
| export 'src/feedback/sentry_feedback_widget.dart' show SentryFeedbackWidget; | ||
| export 'src/flutter_sentry_attachment.dart'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SentryFeedbackWidgetis removed. It was a deprecated typedef alias (typedef SentryFeedbackWidget = SentryFeedbackForm) left over from the rename toSentryFeedbackForm, which is complete.Removes the alias file, its export from
sentry_flutter.dart, and the alias-specific test group. No other code referenced it.Part of the v10 cleanup (#3487).
Breaking change: low impact — already deprecated with a documented migration to
SentryFeedbackForm.Fixes #3825