feat(op): Add span op deprecation support - #621
Open
Lms24 wants to merge 2 commits into
Open
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Names
Other
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
2 tasks
Lms24
force-pushed
the
lms/feat-op-deprecation
branch
from
September 3, 2026 13:00
509fbcb to
d145092
Compare
Lms24
marked this pull request as ready for review
September 3, 2026 14:11
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
September 3, 2026 14:11
Span ops are shipped to SDKs as generated constants, so retiring one needs a deprecation path instead of a deletion. Ops can now carry an optional `deprecation` object with a `replacement` and a `reason`. Deprecated ops keep their constant and get a JSDoc `@deprecated` tag in JavaScript and a `#[deprecated]` attribute in Rust, plus a badge and a replacement notice on the docs site. Kept intentionally light: unlike attribute deprecations there is no `_status`, since this only concerns SDKs and not the ingestion pipeline. No op is deprecated yet — this only adds the mechanism. Fixes GH-619 Co-Authored-By: Claude <noreply@anthropic.com>
Follow-up on the ops page rendering: the notice took up three times the height of a regular row and its reason was hard to read in both themes. - Link the replacement to the row that documents it. - Drop the padded box for a single compact line. - Read the reason in the regular secondary text color, at full opacity. Refs GH-619 Co-Authored-By: Claude <noreply@anthropic.com>
Lms24
force-pushed
the
lms/feat-op-deprecation
branch
from
September 3, 2026 14:51
d145092 to
975e2c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a way to deprecate span ops, like we already have for attributes. An op can now have a
deprecationobject with areplacementand areason. No op is deprecated yet, this only adds the mechanism.deprecationfield in op schema@deprecatedJSDoc in JavaScript constants#[deprecated]attribute on Rust constantsSimpler than attribute deprecation on purpose: no
_status, because this only concerns SDKs and not ingestion.Fixes #619
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.