-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat(attributes): Add legacy AMQP and Redis span attributes (deprecated) #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "key": "db.connection_string", | ||
| "brief": "The connection string used to connect to the database.", | ||
| "type": "string", | ||
| "apply_scrubbing": { | ||
| "key": "auto" | ||
| }, | ||
| "is_in_otel": true, | ||
| "examples": ["redis://localhost:6379"], | ||
| "deprecation": { | ||
| "_status": null, | ||
| "reason": "This attribute is deprecated. The connection is described by server.address and server.port instead, so the value cannot be copied to a single replacement attribute." | ||
|
Comment on lines
+10
to
+12
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good call to not add a replacement here, since it's two attributes that make up for this one. Thanks! |
||
| }, | ||
| "visibility": "public", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [581], | ||
| "description": "Added db.connection_string attribute" | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
model/attributes/messaging/messaging__conversation_id.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "key": "messaging.conversation_id", | ||
| "brief": "The conversation ID identifying the conversation to which the message belongs, represented as a string. Sometimes called \"Correlation ID\".", | ||
| "type": "string", | ||
| "apply_scrubbing": { | ||
| "key": "manual" | ||
| }, | ||
| "is_in_otel": false, | ||
| "examples": ["MyConversationId"], | ||
| "alias": ["messaging.message.conversation_id"], | ||
| "deprecation": { | ||
| "_status": "backfill", | ||
| "replacement": "messaging.message.conversation_id", | ||
| "reason": "This attribute is being deprecated in favor of messaging.message.conversation_id." | ||
| }, | ||
| "visibility": "public", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [581], | ||
| "description": "Added messaging.conversation_id attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "key": "messaging.message_id", | ||
| "brief": "A value used by the messaging system as an identifier for the message, represented as a string.", | ||
| "type": "string", | ||
| "apply_scrubbing": { | ||
| "key": "manual" | ||
| }, | ||
| "is_in_otel": false, | ||
| "examples": ["452a7c7c7c7048c2f887f0e7"], | ||
| "alias": ["messaging.message.id"], | ||
| "deprecation": { | ||
| "_status": "backfill", | ||
| "replacement": "messaging.message.id", | ||
| "reason": "This attribute is being deprecated in favor of messaging.message.id." | ||
| }, | ||
| "visibility": "public", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [581], | ||
| "description": "Added messaging.message_id attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "key": "messaging.operation", | ||
| "brief": "The name of the messaging operation being performed.", | ||
| "type": "string", | ||
| "apply_scrubbing": { | ||
| "key": "manual" | ||
| }, | ||
| "is_in_otel": false, | ||
| "examples": ["publish"], | ||
| "alias": ["messaging.operation.name"], | ||
| "deprecation": { | ||
| "_status": "backfill", | ||
| "replacement": "messaging.operation.name", | ||
| "reason": "This attribute is being deprecated in favor of messaging.operation.name." | ||
| }, | ||
| "visibility": "public", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [581], | ||
| "description": "Added messaging.operation attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "key": "messaging.protocol", | ||
| "brief": "OSI application layer or non-OSI equivalent.", | ||
| "type": "string", | ||
| "apply_scrubbing": { | ||
| "key": "manual" | ||
| }, | ||
| "is_in_otel": false, | ||
| "examples": ["AMQP"], | ||
| "alias": ["network.protocol.name", "net.protocol.name", "mcp.resource.protocol"], | ||
| "deprecation": { | ||
| "_status": "backfill", | ||
| "replacement": "network.protocol.name", | ||
| "reason": "This attribute is being deprecated in favor of network.protocol.name." | ||
| }, | ||
| "visibility": "public", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [581], | ||
| "description": "Added messaging.protocol attribute" | ||
| } | ||
| ] | ||
| } |
24 changes: 24 additions & 0 deletions
24
model/attributes/messaging/messaging__protocol_version.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "key": "messaging.protocol_version", | ||
| "brief": "The actual version of the protocol used for network communication.", | ||
| "type": "string", | ||
| "apply_scrubbing": { | ||
| "key": "manual" | ||
| }, | ||
| "is_in_otel": false, | ||
| "examples": ["0.9.1"], | ||
| "alias": ["network.protocol.version", "http.flavor", "net.protocol.version"], | ||
| "deprecation": { | ||
| "_status": "backfill", | ||
| "replacement": "network.protocol.version", | ||
| "reason": "This attribute is being deprecated in favor of network.protocol.version." | ||
| }, | ||
| "visibility": "public", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [581], | ||
| "description": "Added messaging.protocol_version attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
model/attributes/messaging/messaging__rabbitmq__routing_key.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "key": "messaging.rabbitmq.routing_key", | ||
| "brief": "RabbitMQ message routing key.", | ||
| "type": "string", | ||
| "apply_scrubbing": { | ||
| "key": "manual" | ||
| }, | ||
| "is_in_otel": false, | ||
| "examples": ["myKey"], | ||
| "alias": ["messaging.rabbitmq.destination.routing_key"], | ||
| "deprecation": { | ||
| "_status": "backfill", | ||
| "replacement": "messaging.rabbitmq.destination.routing_key", | ||
| "reason": "This attribute is being deprecated in favor of messaging.rabbitmq.destination.routing_key." | ||
| }, | ||
| "visibility": "public", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [581], | ||
| "description": "Added messaging.rabbitmq.routing_key attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "key": "messaging.url", | ||
| "brief": "The connection string of the messaging broker.", | ||
| "type": "string", | ||
| "apply_scrubbing": { | ||
| "key": "auto" | ||
| }, | ||
| "is_in_otel": false, | ||
| "examples": ["amqp://guest:guest@localhost:5672"], | ||
| "alias": ["url.full", "http.url", "url", "aws.request.url"], | ||
| "deprecation": { | ||
| "_status": "backfill", | ||
| "replacement": "url.full", | ||
| "reason": "This attribute is being deprecated in favor of url.full." | ||
| }, | ||
| "visibility": "public", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [581], | ||
| "description": "Added messaging.url attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.