ref: Replace test key LazyLock statics with compile-time constants#510
Open
jan-auer wants to merge 1 commit into
Open
ref: Replace test key LazyLock statics with compile-time constants#510jan-auer wants to merge 1 commit into
jan-auer wants to merge 1 commit into
Conversation
Use include_str! and concat!(env!()) so test keys and paths are embedded at compile time instead of read from disk at runtime via LazyLock. Removes a duplicate LazyLock in the Rust client tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
==========================================
- Coverage 87.47% 87.46% -0.02%
==========================================
Files 86 86
Lines 13912 13900 -12
==========================================
- Hits 12169 12157 -12
Misses 1743 1743
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lcian
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile-time
include_str!/concat!(env!())instead of runtimeLazyLock<fs::read_to_string>— cheaper, no blocking I/O from async test bodies, and removes a duplicate definition in the Rust client tests.