fix(ci): make gocd asset upload retry-safe#502
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
lcian
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as getsentry/relay#6105, for objectstore's GoCD asset upload.
When the upload fails partway, re-running it fails: the
gha-gcr-pushSA can only create objects, not replace them, and re-uploading an object that already exists counts as replacing it (which needs delete). We switch togcloud storage cp --no-clobber, which skips objects that already exist instead of replacing them, so a re-run is safe and needs no delete permission.The read grant the SA needs for this is in getsentry/devinfra-deployment-service#880. No composite-upload change here, since this step only uploads the small
release-namefile.