Skip to content

feat(server): Add jemalloc stats as Datadog metrics#501

Merged
jan-auer merged 1 commit into
mainfrom
feat/jemalloc-metrics
Jun 17, 2026
Merged

feat(server): Add jemalloc stats as Datadog metrics#501
jan-auer merged 1 commit into
mainfrom
feat/jemalloc-metrics

Conversation

@jan-auer

@jan-auer jan-auer commented Jun 17, 2026

Copy link
Copy Markdown
Member

Objectstore shows RSS growth over time in production. Before investing in heap profiling, we need to distinguish real allocation growth from allocator fragmentation. This adds four jemalloc internal stats as Datadog gauges emitted on the existing metrics_interval (default 10s): jemalloc.allocated, jemalloc.active, jemalloc.resident, and jemalloc.mapped. Comparing allocated (what the app requested) against resident (what the OS reports) will make that distinction visible in production.

Also bumps tikv-jemallocator from 0.6.1 to 0.7.0 (jemalloc 5.3.1, no breaking changes) and adds tikv-jemalloc-ctl 0.7.0 with the stats feature. Both must be the same version to link against the same tikv-jemalloc-sys.

@jan-auer jan-auer marked this pull request as ready for review June 17, 2026 14:45
@jan-auer jan-auer requested a review from a team as a code owner June 17, 2026 14:45
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.39%. Comparing base (cfee5af) to head (106008b).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
objectstore-server/src/state.rs 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
+ Coverage   87.37%   87.39%   +0.02%     
==========================================
  Files          86       86              
  Lines       13761    13825      +64     
==========================================
+ Hits        12023    12082      +59     
- Misses       1738     1743       +5     
Components Coverage Δ
Rust Backend 92.19% <96.29%> (-0.01%) ⬇️
Rust Client 80.06% <ø> (+0.35%) ⬆️
Python Client 88.51% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread objectstore-server/src/state.rs
Comment thread objectstore-server/src/state.rs
@jan-auer jan-auer merged commit c74e688 into main Jun 17, 2026
25 checks passed
@jan-auer jan-auer deleted the feat/jemalloc-metrics branch June 17, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants