chore(tasks) Switch to taskbroker-client metrics#635
Conversation
I'm reworking client metrics for taskbroker clients and this aligns launchpad with that direction. The existing metric names will continue to emit alongside an unprefixed metric. The unprefixed metric will have both `application` and `processing_pool` as tags. Refs STREAM-1173
📲 Install BuildsiOS
Android
|
| processing_pool="launchpad", | ||
| statsd_host=host, | ||
| statsd_port=port, | ||
| enable_prefixed_metrics=True, |
There was a problem hiding this comment.
Once this has rolled out and dashboards have been updated, I'll do another change to remove this.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c9b8fbc. Configure here.
| processing_pool="launchpad", | ||
| statsd_host=host, | ||
| statsd_port=port, | ||
| enable_prefixed_metrics=True, |
There was a problem hiding this comment.
Hardcoded processing pool tag
Medium Severity
create_metrics always sets processing_pool to launchpad, but the worker can be started with a different --processing-pool-name that is only passed to TaskWorker. Unprefixed taskbroker metrics will then carry the wrong processing_pool tag relative to the pool the worker actually joins.
Reviewed by Cursor Bugbot for commit c9b8fbc. Configure here.
There was a problem hiding this comment.
Unprefixed taskbroker metrics will then carry the wrong processing_pool tag relative to the pool the worker actually joins.
Not true, when a worker has a processing pool name provided, that name will be used instead. This is meant as a fallback.
1 participant
I'm reworking client metrics for taskbroker clients and this aligns launchpad with that direction.
The existing metric names will continue to emit alongside an unprefixed metric. The unprefixed metric will have both
applicationandprocessing_poolas tags.Refs STREAM-1173