test: enforce shared SQL fixtures - #1882
Merged
Merged
Conversation
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
1 screenshot change — 1 changed · 0 added · 0 removed Review screenshots in Frameshift
|
Co-Authored-By: David Cramer <david@sentry.io>
dcramer
marked this pull request as ready for review
September 17, 2026 21:12
dcramer
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use one shared SQL fixture boundary for Junior tests.
createJuniorSqlFixture, which opens a rollback-only transaction against the migrated per-worker Postgres database.Evidence:
slack-schedule-tools.test.tstook 54.9–107.5 seconds and created a new database plus applied 43 migrations for each of 52 tests.Checks:
pnpm test-architecture:checkpnpm --filter @sentry/junior typecheckpnpm --filter @sentry/junior exec vitest run --maxWorkers=2 --testTimeout=20000 tests/integration/slack-schedule-tools.test.tspnpm --filter @sentry/junior exec vitest run tests/component/artifacts.test.ts tests/component/conversation-message-search.test.tspnpm --filter @sentry/junior exec vitest run --testTimeout=20000 tests/integration/workspace-snapshot-migration.test.tsvia David Cramer.
--
View Junior Session [Sentry]