fix(slack): treat null search arguments as omitted - #1880
Merged
Merged
Conversation
Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
approved these changes
Sep 17, 2026
dcramer
marked this pull request as ready for review
September 17, 2026 20:00
sentry-junior
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack public search can receive
nullfor optional arguments when a model provider requires every tool field. The tool did not accept that shape, so the model used placeholder values that Slack rejected.Accept
nullfor optional search arguments and omit those values from the Slack request. Cover the model-facing input and outbound Slack request in the existing integration test.via David Cramer.
--
View Junior Session [Sentry]