fix(slack): Ignore message edits - #1872
Merged
Merged
Conversation
Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ilure Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
…ilure Co-Authored-By: David Cramer <david@sentry.io>
dcramer
marked this pull request as ready for review
September 17, 2026 02:21
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit af4814f. Configure here.
Co-Authored-By: David Cramer <david@sentry.io>
github-actions
Bot
added
risk: high
dcramer
reviewed
Sep 17, 2026
Keep accepted Conversation Messages immutable. Slack message_changed events no longer create replacement Messages or start Turns, and the dashboard no longer needs an edited-message projection workaround. Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
Allow ordinary English that says an event automation watches a resource. Keep rejecting claims that the temporary watchEvents tool or a polling schedule was created. Co-Authored-By: David Cramer <david@sentry.io>
Name the two facts directly: whether input still needs a durable copy, and whether a history branch must fail the progress write. Document why only direct Slack input needs this before acknowledgement. Co-Authored-By: David Cramer <david@sentry.io>
Keep the fix at Slack ingress by ignoring edits. Remove the special agent checkpoint behavior and its history-branch test changes because Slack input now follows the same durable mailbox contract as other work. Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
dcramer
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message_changedevents.Why
A Slack edit could synthesize a second Conversation Message and start another Turn for the same Slack Message. That can duplicate input and show a false “Context from” row.
Edits now do nothing. They cannot rewrite transcript history, append a replacement Message, or start or repeat a Turn. A user must send a new Message or reply with
@juniorinstead.The prior checkpoint policy was removed. Slack input uses the same agent checkpoint behavior as other sources; this PR fixes the producer at Slack ingress instead of adding recovery logic to the shared runtime.
Evidence
Verification
via David Cramer.
--
View Junior Session [Sentry]